Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Ruby lock #41

Closed
roberts1000 opened this issue Jun 22, 2019 · 0 comments · Fixed by #42
Closed

Remove Ruby lock #41

roberts1000 opened this issue Jun 22, 2019 · 0 comments · Fixed by #42
Assignees
@roberts1000
Labels
enhancement New feature or request
Milestone
1.2.2

Comments

@roberts1000
Copy link
Owner

roberts1000 commented Jun 22, 2019 •
edited
Loading

A default Ruby is specified in the Gemfile, which is useful for development, but makes it hard to test different versions of Ruby on travis.

  1. Add s.required_ruby_version = '>= 2.3.0' to the gemspec to set the minimum Ruby that's supported.
  2. Remove the ruby line from the Gemfile. Development can happen on any Ruby that's supported. Rubocop and automated tests will catch problems with Ruby.
  3. Update rubocop.yml to target Ruby 2.3.8.
@roberts1000 roberts1000 self-assigned this Jun 22, 2019
@roberts1000 roberts1000 added the enhancement New feature or request label Jun 22, 2019
@roberts1000 roberts1000 added this to the Next Release milestone Jun 22, 2019
@roberts1000 roberts1000 mentioned this issue Jun 22, 2019
Merged
roberts1000 added a commit that referenced this issue Jun 22, 2019
@roberts1000
Merge pull request #42 from roberts1000/41_remove_default_ruby
472fdee 
[PR for issue #41] Remove default ruby
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roberts1000 roberts1000

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.2
Development

Successfully merging a pull request may close this issue.

[PR for issue #41] Remove default ruby roberts1000/rspec_n
1 participant
@roberts1000