Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coinbase Transactions Aren't Processed #16

Closed
noahShinabarger opened this issue Jan 1, 2021 · 3 comments
Closed

Coinbase Transactions Aren't Processed #16

noahShinabarger opened this issue Jan 1, 2021 · 3 comments

Comments

@noahShinabarger
Copy link

Coinbase must have changed the format of the .csv they make available; the rows are much different than as specified in the Coinbase parser and the entire parser will need to be updated.

@pappde
Copy link

pappde commented Feb 6, 2021

I haven't tried the Coinbase one, but I tried the Coinbase Pro one. Make sure to use the "Fills" export, not "Accounts". You have to remove the first column "portfolio" and then it will work using the GdaxFillsParser. It should be easy to update the code to recognize that first "portfolio" column.

However, I'm not sure the script is working. Perhaps it's only handling transactions on a USD exchange, since it doesn't seem to report anything on a BTC exchange.

@robertwb
Copy link
Owner

robertwb commented Feb 7, 2021

I've updated the scripts to also understand the new format for Coinbase Pro. You're right, it only understands (at the moment) the USD-BTC accounts. Note that you need both "fills" and "accounts" to track cost basis of deposits and withdrawals (though fills alone is sufficient if no BTC was deposited/withdrawn).

As for the "vanilla" Coinbase, these have changed dramatically (and not for the better, e.g. there seems to be no information about the wallet or manually entered notes for a transaction). This'll have to be updated.

robertwb added a commit that referenced this issue Feb 7, 2021
This addresses part of #16.
@robertwb
Copy link
Owner

robertwb commented Feb 9, 2021

Coinbase's new format no longer contains all the information needed to track cost basis. I created a new script that uses their API to download this information into a format that the main script can then use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants