Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Border Frame on Xamarin.forms 3.0 #44

Closed
Phenek opened this issue May 11, 2018 · 11 comments
Closed

[Update] Border Frame on Xamarin.forms 3.0 #44

Phenek opened this issue May 11, 2018 · 11 comments

Comments

@Phenek
Copy link

Phenek commented May 11, 2018

Hello,

Xamarin.Forms 3.0 has just been released and they fix the issue on Android with border line frame.

So now we could just use one Frame to make appear the Border of it.
And It could also allow us, to get a button with transparent Background but borderer

Let me know about your expectation,
Regards,

@IeuanWalker
Copy link
Contributor

@Clovs Does this relate to the fact that all flex buttons in the app now has a white border since I updated to version 3. Or should I create a new issue for it?

@Phenek
Copy link
Author

Phenek commented May 21, 2018

Yeah, the new Xamarin.Forms 3.0 is making the Frame with border thickness to One on Android by default.
(thickness : Zero on iOS... but before the border wasn't showing at all on Android, So not bad :))
No need to open an new issue for it, cause it's all about the Xamarin.Forms 3.0 here.

@IeuanWalker
Copy link
Contributor

@Clovs Ahh thanks for the update. So how would I fix this for my solution, because it's happening for other controls too?

@Phenek
Copy link
Author

Phenek commented May 22, 2018

For FlexButtons you have to wait until next update of the package.
For your others controls that use Frame Component, you have to set the BoderColor property to Color.transparent.

@IeuanWalker
Copy link
Contributor

IeuanWalker commented May 22, 2018

@Clovs Great thanks, when do you reckon the NuGet will be updated. Becuase at the moment, the app is due to be released for the first time on the 31st, and as our app is dark themed the only other solution seems to be, remove FlexButton and try and get the default button to look ok (which we really don't want to do).

@Phenek
Copy link
Author

Phenek commented May 23, 2018

I have no time to make a PR for the moment.
But you just have to copy & past to your project this two file from: the repo
And but BoderColor property of Frames in the Xaml to Color.transparent.

Then you have to use your new flexbutton Class, with your local namespace.

@IeuanWalker
Copy link
Contributor

IeuanWalker commented May 23, 2018

@Clovs Great thanks , ill give it a go :)

@robinmanuelthiel
Copy link
Owner

Hey guys! I don't think, we can use the Xamarin.Forms 3.0 implementation for Borders right now, as it is still very buggy (xamarin/Xamarin.Forms#2634) and does not have border thickness. As the whole concept of this project is flexibility, I think we should stick with our implementation for now.

I will provide a quick-fix for xamarin/Xamarin.Forms#2634 on Android within the next days!

@Phenek
Copy link
Author

Phenek commented May 24, 2018

Well it looks fine to me, Thanks. :)

@robinmanuelthiel
Copy link
Owner

robinmanuelthiel commented May 24, 2018

Fixed (workaround) in v0.7.0: https://www.nuget.org/packages/Forms.Controls.FlexButton/0.7.0
Make sure to update your projects to .NET Standard 2.0 before!

@IeuanWalker
Copy link
Contributor

@robinmanuelthiel awesome thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants