-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Update] Border Frame on Xamarin.forms 3.0 #44
Comments
@Clovs Does this relate to the fact that all flex buttons in the app now has a white border since I updated to version 3. Or should I create a new issue for it? |
Yeah, the new Xamarin.Forms 3.0 is making the Frame with border thickness to One on Android by default. |
@Clovs Ahh thanks for the update. So how would I fix this for my solution, because it's happening for other controls too? |
For FlexButtons you have to wait until next update of the package. |
@Clovs Great thanks, when do you reckon the NuGet will be updated. Becuase at the moment, the app is due to be released for the first time on the 31st, and as our app is dark themed the only other solution seems to be, remove FlexButton and try and get the default button to look ok (which we really don't want to do). |
I have no time to make a PR for the moment. Then you have to use your new flexbutton Class, with your local namespace. |
@Clovs Great thanks , ill give it a go :) |
Hey guys! I don't think, we can use the Xamarin.Forms 3.0 implementation for Borders right now, as it is still very buggy (xamarin/Xamarin.Forms#2634) and does not have border thickness. As the whole concept of this project is flexibility, I think we should stick with our implementation for now. I will provide a quick-fix for xamarin/Xamarin.Forms#2634 on Android within the next days! |
Well it looks fine to me, Thanks. :) |
Fixed (workaround) in v0.7.0: https://www.nuget.org/packages/Forms.Controls.FlexButton/0.7.0 |
@robinmanuelthiel awesome thanks a lot |
Hello,
Xamarin.Forms 3.0 has just been released and they fix the issue on Android with border line frame.
So now we could just use one Frame to make appear the Border of it.
And It could also allow us, to get a button with transparent Background but borderer
Let me know about your expectation,
Regards,
The text was updated successfully, but these errors were encountered: