Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e-square-io/nx-affected-matrix github action fails because of missing root property in project.json #216

Closed
robinpellegrims opened this issue May 15, 2023 · 0 comments · Fixed by #217
Closed

e-square-io/nx-affected-matrix github action fails because of missing root property in project.json #216

robinpellegrims opened this issue May 15, 2023 · 0 comments · Fixed by #217
Assignees
@robinpellegrims
Labels
type:bug Something isn't working

Comments

@robinpellegrims
Copy link
Owner

Describe the bug
e-square-io/nx-github-actions#53
This is blocking every update of nx since the schematics keep on removing the root property from all project.json.

To Reproduce
remove root property in any project.json file, push to github and see first step of ci flow fail

Expected behavior
first step of ci flow should succesfully determine the affected projects

Solution
e-square-io/nx-github-actions#53 (comment)
@robinpellegrims robinpellegrims self-assigned this May 15, 2023
@robinpellegrims robinpellegrims added the type:bug Something isn't working label May 15, 2023
robinpellegrims added a commit that referenced this issue May 15, 2023
@robinpellegrims
ci: automatically add root property to project.json
c143998 
fixes #216
@robinpellegrims robinpellegrims linked a pull request May 15, 2023 that will close this issue
216 e square ionx affected matrix GitHub action fails because of missing root property in projectjson #217
Merged
robinpellegrims added a commit that referenced this issue May 15, 2023
@robinpellegrims
ci: automatically add root property to project.json
1da1f09 
fixes #216
robinpellegrims added a commit that referenced this issue May 15, 2023
@robinpellegrims
ci: automatically add root property to project.json
5040949 
fixes #216
robinpellegrims added a commit that referenced this issue May 15, 2023
@robinpellegrims
ci: automatically add root property to project.json
43ec884 
fixes #216
@robinpellegrims robinpellegrims mentioned this issue May 15, 2023
Merged
robinpellegrims added a commit that referenced this issue May 15, 2023
@robinpellegrims
ci: automatically add root property to project.json
1ca3a02 
fixes #216
robinpellegrims added a commit that referenced this issue May 15, 2023
@robinpellegrims
ci: automatically add root property to project.json
44ccffa 
fixes #216
robinpellegrims added a commit that referenced this issue May 15, 2023
@robinpellegrims
ci: automatically add root property to project.json
9ea5e8b 
fixes #216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinpellegrims robinpellegrims

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@robinpellegrims