SWIG 4.1.1 #122
Merged
SWIG 4.1.1 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not the nicest but at least it works.
We're already ignoring other IOStream methods. This one was added in a later TagLib, which we don't build against yet, but I thought it might be nice to make running swig against later versions work.
See previous commits for fixes we needed to do to make a newer swig work.
robinst
commented
Dec 19, 2022
fusion2004
approved these changes
Dec 19, 2022
|
I have also checked that running |
jacobvosmaer
approved these changes
Dec 27, 2022
|
Just released this change as 1.1.3 on rubygems: https://rubygems.org/gems/taglib-ruby |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for changes. The main one is in
ext/taglib_base/taglib_base.ito fix the%renameto work with SWIG 4.1.0 and later, see #115 (comment).Apart from SWIG related changes, there should be no other changes in the wrapper files. If someone else could double check that, that would be nice.