Use "defined" in DBM::Deep::Array::PUSH

[jes]

This way it is possible to push 0's and empty strings.

https://rt.cpan.org/Public/Bug/Display.html?id=85414

[jes]

Note this still doesn't fix this code entirely.

Consider:

push @a, undef, "hello";

With normal arrays this works fine, but here it will break the loop before pushing "hello". I'm not sure what to do about this.

[jes]

Should be sorted now.

[robkinyon]

Jes -

What do you think about switching the code to something like:

while ( length @_ ) {
    $self->STORE( $length, shift(@_) );
    $length++;
}

That way, we don't care what the thing is at all. We just care that a thing was passed in, whatever it is.

If you think that works, please amend the patch and (most importantly!) add tests. All the test cases you've suggested are good ideas. :)

And, finally, please add yourself to the CONTRIBUTORS list in the DBM/Deep.pod file.

[jes]

That won't work:

$ perl -e '@a = (); print length(@a), "\n"'
1

The length will never get to 0. For now I'll just add the test and CONTRIBUTORS line. Feel free to change the loop to

while ( @_ ) {
    $self->STORE( $length, shift(@_) );
    $length++;
}

Personally, I think the for loop version is nicer.

[jes]

I think this is suitable for merging now, unless there is anything else you would like me to change?

[jes]

Anything I could do to help?

[robkinyon]

Merged and released. Thanks!

On Tue, Jun 4, 2013 at 9:05 AM, James Stanley [email protected]:

Anything I could do to help?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-18919630
.

Thanks,
Rob Kinyon

[jes]

Cheers Rob :)

[cpansprout]

Thank you, Rob, for taking care of this and other issues. I just have not had time lately to do anything with DBM::Deep.

[robkinyon]

No worries. That's why there's two of us.

On Fri, Jul 19, 2013 at 12:48 PM, cpansprout [email protected]:

Thank you, Rob, for taking care of this and other issues. I just have not
had time lately to do anything with DBM::Deep.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-21273009
.

Thanks,
Rob Kinyon