Split all gympp resources to a separated folder #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of ign-physics would otherwise complain
SWIG can access directly the struct attributes
diegoferigo
requested review from
traversaro,
raffaello-camoriano and
paolo-viceconte
diegoferigo
force-pushed
the
refactor/split_gympp
branch
from
e57c601 to
798f86a
Compare
diegoferigo
force-pushed
the
refactor/split_gympp
branch
from
798f86a to
81fe00a
Compare
traversaro
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gympprepresents the earliest attempt of this project. Is mainly a C++ implementation of OpenAI Gym. After the initial development, we started focusing more on using the gazebo bindings directly from Python. The gympp classes didn't see much development since.As a subtask of #155, this PR makes more order to the project and splits all the gympp-related resources to the new
cpp/gymppfolder.The diff is quite big, but it's just code moved from one place to another plus minor namespace changes. Tests are all passing :)