Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate idiomatic undercase Python bindings #193

Merged
merged 8 commits into from
May 1, 2020
Merged

Generate idiomatic undercase Python bindings #193

merged 8 commits into from
May 1, 2020

Conversation

diegoferigo
Copy link
Collaborator

@diegoferigo diegoferigo commented May 1, 2020 •
edited
Loading

@diegoferigo diegoferigo requested a review from traversaro May 1, 2020 09:20
@diegoferigo diegoferigo self-assigned this May 1, 2020
@diegoferigo diegoferigo changed the title Generate idiomatic lowercase Python bindings Generate idiomatic undercase Python bindings May 1, 2020
@diegoferigo diegoferigo mentioned this pull request May 1, 2020
Merged
7 tasks
traversaro
traversaro approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably kind of obvious for Python users, but in general I would refer to PEP 8 to explain where the rules for "idiomatic Python" came from.

@diegoferigo
Copy link
Collaborator Author

Thanks for the link to the proposal, it's worth mentioning.

@diegoferigo diegoferigo merged commit a3c899b into robotology-legacy:refactoring May 1, 2020
@diegoferigo diegoferigo deleted the refactor/idiomatic_python_bindings branch May 1, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

Assignees

@diegoferigo diegoferigo

Labels
complexity::medium component::gym_ignition pr::resolution::merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegoferigo @traversaro