-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Github Actions Workflows and Docker Images #194
Update Github Actions Workflows and Docker Images #194
Conversation
c29a5b9
to
76e1d6c
Compare
76e1d6c
to
9d41b81
Compare
9d41b81
to
29d42e4
Compare
else() | ||
find_package(ignition-gazebo3 REQUIRED) | ||
endif() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today during the final polishing I found my setup in the situation where I wanted to generate a PyPI package but CMake did not find Ignition Gazebo. Without this if statement, the generation of the package (launched by setuptools from setup.py
) will succeed. In fact, in this case the CMake project would not fail and I was obtaining a PyPI package with just the Python files.
This is very dangerous in the case of a bugged Docker image used for packaging (remember that it is autogenerated with cron weekly builds). It would result to a uncomplete package pushed to PyPI.
master
anddevel
images are now differentdocker-compose
to build imagesdevel
images build Ignition Robotics from sources