Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github Actions Workflows and Docker Images #194

Conversation

diegoferigo
Copy link
Collaborator

  • master and devel images are now different
  • Unified CI and CD dockerfiles (they still generate different images)
  • Use docker-compose to build images
  • devel images build Ignition Robotics from sources

@diegoferigo diegoferigo force-pushed the refactor/dockerfiles_and_gha branch from 76e1d6c to 9d41b81 Compare May 2, 2020 11:39
@diegoferigo diegoferigo force-pushed the refactor/dockerfiles_and_gha branch from 9d41b81 to 29d42e4 Compare May 2, 2020 11:43
else()
find_package(ignition-gazebo3 REQUIRED)
endif()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today during the final polishing I found my setup in the situation where I wanted to generate a PyPI package but CMake did not find Ignition Gazebo. Without this if statement, the generation of the package (launched by setuptools from setup.py) will succeed. In fact, in this case the CMake project would not fail and I was obtaining a PyPI package with just the Python files.

This is very dangerous in the case of a bugged Docker image used for packaging (remember that it is autogenerated with cron weekly builds). It would result to a uncomplete package pushed to PyPI.

@diegoferigo diegoferigo merged commit 34c9254 into robotology-legacy:refactoring May 2, 2020
@diegoferigo diegoferigo deleted the refactor/dockerfiles_and_gha branch May 2, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants