Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selecting whether to use system dependencies or download vendored #275

Merged

Conversation

diegoferigo
Copy link
Collaborator

@diegoferigo diegoferigo commented Nov 17, 2020

Fix #256.

Latest CMake refactoring done in #233.

@diegoferigo
Copy link
Collaborator Author

I got the following error when packaging the wheel (and not when builiding the plain CMake project):

CMake Error: install(EXPORT "ScenarioGazeboExport" ...) includes target "GazeboSimulator" which requires target "tiny-process-library" that is not in any export set.
CMake Error in cpp/scenario/gazebo/CMakeLists.txt:
export called with target "GazeboSimulator" which requires target
"tiny-process-library" that is not in any export set.

Error in CI here.

Last time I had to resort to a workaround that I tried to remove in a27723e. Apparently is still required. Trying another alternative in 9da3a7a from https://gitlab.kitware.com/cmake/cmake/-/issues/15415#note_634114.

cc @traversaro

@traversaro
Copy link
Contributor

Another related issue may be https://gitlab.kitware.com/cmake/cmake/-/issues/18935 . In general OBJECT libraries and installations are definitely an area of CMake that is not really robust at the moment.

@diegoferigo
Copy link
Collaborator Author

Another related issue may be https://gitlab.kitware.com/cmake/cmake/-/issues/18935 . In general OBJECT libraries and installations are definitely an area of CMake that is not really robust at the moment.

Yep, the fix didn't solve it:

CMake Error in cpp/scenario/gazebo/CMakeLists.txt:
export called with target "GazeboSimulator" which requires target
"tiny-process-library" that is not in any export set.

@diegoferigo diegoferigo force-pushed the feature/improve_external_deps branch from 9da3a7a to 91c690b Compare November 17, 2020 14:17
@diegoferigo
Copy link
Collaborator Author

diegoferigo commented Nov 17, 2020

I tried with STATIC library but when packaging the wheel, the .a of TPL gets included and I don't like that. I reverted to OBJECT. In this case, a new exported target ScenarioGazebo::tiny-process-library is created but it looks harmless.

Let's wait CI and merge if this is ok.

@diegoferigo diegoferigo merged commit b588b8f into robotology-legacy:devel Nov 17, 2020
@diegoferigo diegoferigo deleted the feature/improve_external_deps branch November 17, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCENARIO_USE_SYSTEM_TPL does not work
2 participants