Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting BUILD_COMMAND or INSTALL_COMMAND in the Buildxxx.cmake does not have any effect #15

Closed
liesrock opened this issue Nov 28, 2016 · 5 comments
Assignees

Comments

@liesrock
Copy link
Member

liesrock commented Nov 28, 2016

@drdanz what do you think about this?
me and @alaurenzi would like to jump the BUILD e INSTALL steps for the ADVR_shared repo.
It is easy to reproduce the error:

git clone git clone https://github.com/robotology-playground/robotology-superbuild.git -b issue#15 test
cd test && mkdir build 
. robotology-setup.bash
cd build
cmake ..
make ADVR_shared

The output will be:

[ 75%] Performing build step for 'ADVR_shared'
[ 87%] Performing install step for 'ADVR_shared'
make[4]: *** No rule to make target `install'. Stop.
make[3]: *** [configs/ADVR_shared/CMakeFiles/YCMStamp/ADVR_shared-install] Error 2
make[2]: *** [CMakeFiles/ADVR_shared.dir/all] Error 2
make[1]: *** [CMakeFiles/ADVR_shared.dir/rule] Error 2
make: *** [ADVR_shared] Error 2

Here is the BuildADVR_shared.cmake :

# ADVR_shared
include(YCMEPHelper)
include(FindOrBuildPackage)

ycm_ep_helper(  ADVR_shared
                TYPE GIT
                STYLE GITLAB_ADVRCLOUD
                REPOSITORY advr_humanoids/advr_shared.git
                TAG master
                COMPONENT configs
                BUILD_COMMAND ""
                INSTALL_COMMAND ""
            )
@liesrock liesrock changed the title setting BUILD_COMMAND or INSTALL_COMMAND in the Buildxxx.cmake does not have any effects setting BUILD_COMMAND or INSTALL_COMMAND in the Buildxxx.cmake does not have any effect Nov 28, 2016
@drdanz
Copy link
Member

drdanz commented Nov 29, 2016

It might be related to an old issue with CMakeParseArguments for which I had a workaround, but that I cannot remember whether I removed it or not.
Which CMake and YCM versions are you using?

@liesrock
Copy link
Member Author

We are currently using CMake 3.5 with YCM v0.2.2

@drdanz
Copy link
Member

drdanz commented Nov 30, 2016

@liesrock should be fixed in YCM master, please try changing
YCM_TAG to 538bec08ad3e32b4423fe008e79d0eee941e89e9

@drdanz drdanz self-assigned this Nov 30, 2016
@liesrock
Copy link
Member Author

Thanks! It works now!

@drdanz
Copy link
Member

drdanz commented Dec 2, 2016

@liesrock Since this is quite an important issue, I will probably release YCM v0.2.3 in the next few days...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants