Double laser plugin #419
Merged
Double laser plugin #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valegagge
force-pushed
the
doubleLaserPlugin
branch
from
c0f66a0 to
753288d
Compare
valegagge
force-pushed
the
doubleLaserPlugin
branch
from
753288d to
ba78bfa
Compare
randaz81
requested changes
Mar 29, 2019
plugins/doublelaser/CMakeLists.txt
Outdated
| @@ -0,0 +1,29 @@ | |||
| # Copyright (C) 2007-2015 Istituto Italiano di Tecnologia ADVR & iCub Facility & RBCS Department | |||
plugins/doublelaser/CMakeLists.txt
Outdated
| @@ -0,0 +1,29 @@ | |||
| # Copyright (C) 2007-2015 Istituto Italiano di Tecnologia ADVR & iCub Facility & RBCS Department | |||
| # Authors: Enrico Mingo, Alessio Rocchi, Mirko Ferrati, Silvio Traversaro, Alessandro Settimi and Francesco Romano | |||
plugins/doublelaser/CMakeLists.txt
Outdated
|
|
||
| PROJECT(Plugin_DoubleLaser) | ||
|
|
||
| message("sono nel doublelaser!!") |
| } | ||
| else | ||
| { | ||
| yError() << "GazeboYarpDoubleLaser: ERRORE mentre facevo attach di rangeFinder wrapper al double laser."; |
|
|
||
| if(m_iWrap_rangeFinder->attachAll(listofdoubellaser)) | ||
| { | ||
| yError() << "GazeboYarpDoubleLaser: ho fatto attach di rangeFinder wrapper al double laser. OK"; |
| @@ -0,0 +1,267 @@ | |||
| /* | |||
| * Copyright (C) 2013-2015 Fondazione Istituto Italiano di Tecnologia RBCS & iCub Facility & ADVR | |||
| @@ -0,0 +1,70 @@ | |||
| /* | |||
| * Copyright (C) 2013-2015 Fondazione Istituto Italiano di Tecnologia RBCS & iCub Facility & ADVR | |||
| */ | ||
|
|
||
| /** | ||
| * @file DoubleLaser.h |
|
|
||
|
|
||
| /** | ||
| * @file DoubleLaser.h |
|
Very good! Only minor comments, then we can merge! 👍 BTW: I noticed in the last push-force you removed any modifications related to a "set deviceId" method of the lasersensor plugin (I mean, the original-single laser plugin). Is it confirmed? |
DoubleLaser uses this parameter to differentiate front and back lasers
randaz81
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR there is the implementation of double laser Plugin.
It is already tested
cc @randaz81