Add support for loading vector from configuration files with parenthesis #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in robotology/yarp#3092, it is recomendded for future software that uses YARP to use vectors in configuration file by indicating them with parenthesis. gazebo-yarp-plugins used to load the vectors from configuration files expecting no parenthesis. After this commit, now plugins support both the with parentheis and without parenthesis style, printing a warning if the without parenthesis style is used. If you can require gazebo-yarp-plugins 4.11.0, consider switching your configuration files to the vector with parenthesis style.
xela-95
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in robotology/yarp#3092, it is recommended for future software that uses YARP to use vectors in configuration file by indicating them with parenthesis, i.e. to refer to them with:
instead of:
gazebo-yarp-plugins used to load the vectors from configuration files expecting no parenthesis. After this PR, now plugins support both the with parentheis and without parenthesis style, printing a warning if the without parenthesis style is used. If you can require gazebo-yarp-plugins 4.11.0, consider switching your configuration files to the vector with parenthesis style.