Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Move to robotology #19

Closed
diegoferigo opened this issue Jun 14, 2020 · 6 comments
Closed

Move to robotology #19

diegoferigo opened this issue Jun 14, 2020 · 6 comments
Assignees

Comments

@diegoferigo
Copy link
Member

I think it's time to make this repository officially supported by our organization. We're already successfully using these models in our training pipelines with no major problems since few months now.

This repository is a dependency of gym-ignition, that is already inside robotology. It makes sense that also its dependencies will get the same maintenance policy.

cc @traversaro

@traversaro
Copy link
Member

traversaro commented Jun 14, 2020

Yes, the only thing I have some doubts about is that I would prefer to have (even more) possibly outdated iCub models in robotology repos, but that is not a blocking problem.

@diegoferigo
Copy link
Member Author

We discussed the topic in robotology/icub-models#33 and we haven't yet found any long-term solution. Or, at least, I think we agreed that a single model + per-simulator tweaks using simulator-specific resources could be one of the possible long-term solutions. However, since then, no one has yet taken initiative to start such activity.

I think that in the moment we're going to progressively transition towards Ignition Gazebo (and I believe it's going to happen in the next 1 or 2 years), we have to face it anyway. We won't drop Gazebo Classic support.

Although, for the moment, the modification of this iCub model are not major (#1, #9, #15), and gym-ignition-models has reasons to exist in the long run even without the iCub model.

@traversaro
Copy link
Member

Ack, I don't think in any case there is a big difference if the repo is in dic-iit or robotology. However, just to clarify: the problem that I fear is not that there is the same model (with small modifications) in different repos per se, but that the process of converting the model of iCub to be stored in this repo is not automatic, and so in the future the model in this repo could be outdated w.r.t. to the one generated with automatic generation in https://github.com/robotology/icub-models .

@traversaro
Copy link
Member

Done, feel free to close.

@diegoferigo
Copy link
Member Author

Done, feel free to close.

Awesome, thanks!

in the future the model in this repo could be outdated w.r.t. to the one generated with automatic generation in https://github.com/robotology/icub-models

If for some reason in the future this repository becomes unmaintained and it does no longer meet enough requirements to stay in robotology, we can always move it to either robotology-legacy or "downgrade" it to robotology-playground, right?

@traversaro
Copy link
Member

in the future the model in this repo could be outdated w.r.t. to the one generated with automatic generation in https://github.com/robotology/icub-models

If for some reason in the future this repository becomes unmaintained and it does no longer meet enough requirements to stay in robotology, we can always move it to either robotology-legacy or "downgrade" it to robotology-playground, right?

Yes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants