Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Add iCubGazeboV2_5 model #1

Merged
merged 16 commits into from
Feb 4, 2020
Merged

Add iCubGazeboV2_5 model #1

merged 16 commits into from
Feb 4, 2020

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented Feb 3, 2020

The iCub model has been taken from iCubGazeboV2_5/model.urdf and adapted to work in Ignition Gazebo.

iCubGazeboV2_5

@diegoferigo diegoferigo self-assigned this Feb 3, 2020
Copy link
Member

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I would have avoided the indentation only file change 54e430a that will complexifies quick comparison against icub-models's models in the future and porting changes from this repo to icub-models, but I guess this is not blocking the PR.

@diegoferigo
Copy link
Member Author

It speeds up development though :) I didn't consider comparisons, you're right. It's too late now to roll back, a rebase would not work in this case.

@traversaro
Copy link
Member

It speeds up development though :)

Just to understand, why four spaces indent speeds up the development over two spaces indent? Note that those files were already indented programmatically using the pretty_print option of lxml.

@diegoferigo
Copy link
Member Author

It's not the indentation that speeds up the development. Simply, when I save in my setup all files get reformatted, and it happened that I had the 4 spaces enabled by default.

@diegoferigo
Copy link
Member Author

As a workaround, I can format back the file to 2 spaces. One extra commit would not harm :)

@traversaro
Copy link
Member

As a workaround, I can format back the file to 2 spaces. One extra commit would not harm :)

As you prefer, you can even just re-format back when we will need comparisons.

@diegoferigo diegoferigo mentioned this pull request Feb 3, 2020
@diegoferigo diegoferigo force-pushed the robot/icub branch 4 times, most recently from d91f4fa to 5b22b21 Compare February 4, 2020 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants