Add test harness to common supervisor, fix bugs, restore C code calls #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement working test harness and update other models add condition to test Switch to asserts commit change
sup improve test model with checks on bumpless switches Clean up checks
Update test with motor upd Add pmsm to common and make it work with D-axis
pattacini
requested changes
Jan 26, 2024
There was a problem hiding this comment.
Excellent work @mfussi66 🚀
Just a minor request:
- Would you be willing to refactor the
common/testsdir with a further level of subdirs in order to specialize the meaning? For example, the modelpmsmcould be located undercommon/tests/motor; similar subdirs should host the other tests. Avoiding using one shared big bucket will enable us to be a bit cleaner.
|
Remember to update the project to include the new tree. |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a test harness model embedded in the new
Supervisor.slx, located in theCommonproject.The model is as follows:
On the left we have a test sequence object, and on the right a test assessment block. The first sets the input variables, while the other verifies them according to internal rules.
This harness model allowed to discover a bug caused by the refactor in the Input Dispatcher. See the issue related to this PR for details: #72
Finally, custom code calls are restored.