Add eOmc_kalman_filter_config_t to EoMotionControl #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicogene
reviewed
Jun 17, 2022
There was a problem hiding this comment.
Maybe it is the case of bumping the patch number and requiring it in robotology/icub-main#799?
marcoaccame
requested changes
Jun 21, 2022
There was a problem hiding this comment.
Hi @sgiraz: when you change the format of data of a protocol entity traveling over a UDP frame
you also nee to change the protocol version of the relevant entity.
In our case, you increased / changed eOmc_joint_config_t, so you need to increment also: https://github.com/robotology/icub-firmware-shared/blob/devel/eth/embobj/plus/comm-v2/protocol/api/EoProtocolMC.h#L60
Sadly, you also need to rebuild the binaries in here.
marcoaccame
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What chages this PR:
eOmc_kalman_filter_config_ttoEoMotionControlin order to allow the transfer of Kalman Filter configuration parameter between theicub-mainandicub-firnware.eOmc_joint_config_tandeOmc_joint_tstructures to take account of the size of the neweOmc_kalman_filter_config_tstructureNotes:
None