-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added calibration 14 data struct #81
Conversation
Hi @valegagge Probably, we should handle the package versioning. cc @valegagge |
linked to: it probably needs a PR also on https://github.com/robotology/icub-firmware-build |
yes |
Oh yes for sure!! I'll add it asap!!! |
Yes, we are doing it |
I updated the version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is OK by me.
However, we shall merge it only when the other PRs are OK. See:
In this PR we added the data related to calibration 14: it is used for the open close joint f ergoCub fingers.
Important note
Even if the calibration 14 parameters hosts both motor encoder info and joint encoder (
FAP
)info, currently only the data regarding the motor encoder are used:pwmlimit
andfinal_pos.
Related PRs:
cc @MSECode