Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added calibration 14 data struct #81

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

valegagge
Copy link
Member

@valegagge valegagge commented Apr 6, 2023

In this PR we added the data related to calibration 14: it is used for the open close joint f ergoCub fingers.

Important note

Even if the calibration 14 parameters hosts both motor encoder info and joint encoder (FAP)info, currently only the data regarding the motor encoder are used: pwmlimit and final_pos.


Related PRs:

cc @MSECode

@valegagge valegagge requested a review from marcoaccame April 6, 2023 15:46
@pattacini
Copy link
Member

Hi @valegagge

Probably, we should handle the package versioning.
Consequently, icub-main@devel should be upgraded to link to the latest version.

cc @valegagge

@marcoaccame
Copy link
Contributor

@marcoaccame
Copy link
Contributor

Hi @valegagge

Probably, we should handle the package versioning. Consequently, icub-main@devel should be upgraded to link to the latest version.

cc @valegagge

yes

@valegagge
Copy link
Member Author

Oh yes for sure!! I'll add it asap!!!

@valegagge
Copy link
Member Author

linked to:

it probably needs a PR also on https://github.com/robotology/icub-firmware-build

Yes, we are doing it

@valegagge
Copy link
Member Author

valegagge commented Apr 6, 2023

I updated the version of icub-firmware-shared to 1.34.1 and updated according icub-main

Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcoaccame marcoaccame merged commit 60e826d into robotology:devel Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants