mc4plus double pinout #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicogene
approved these changes
Sep 7, 2023
|
pattacini
reviewed
Sep 11, 2023
pattacini
approved these changes
Sep 12, 2023
Add strcut and method for converting status int to string understandable by user Re-defined status enum and type and add bat type inclusion to supported can boards Update icub_firmware_shared_VERSION in CMakeLists.txt Adjust bms enum values for starting from bit_pos=1
pattacini
reviewed
Sep 14, 2023
|
Hi @davidetome There's a conflict to be addressed. |
pattacini
approved these changes
Sep 14, 2023
Nicogene
approved these changes
Sep 14, 2023
|
Ok also for me, a i would "squash and merge" @marcoaccame |
marcoaccame
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Hi @davidetome the PR is OK, but as you changed the version you need to make a PR on icub-main as well.
I can do that myself once this PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the modified mc4plus in order to drive two motors instead of four but with doubled current absorption.