Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the MAS client usage in WholeBodyDynamics #596

Merged
merged 22 commits into from
Oct 9, 2019

Conversation

Nicogene
Copy link
Member

Preface: I honestly don't know how the imu data is used in this module, i just kept the logic.

This PR add the possibility to make communicate the IMU and WholeBodyDynamics using the multipleanalogsensorclient.

cc @marcoaccame

@Nicogene
Copy link
Member Author

Nicogene commented Aug 27, 2019

I noticed that for gravityCompensator no changes are required. It gets the inertial data reading form output streaming port of wholeBodyDinamics, not directly from the imu.

@traversaro correct me if I am wrong.

I added to this PR some cleanup commit of gravityCompensator.

@traversaro
Copy link
Member

@traversaro correct me if I am wrong.

Exactly, that is correct as far as I remember.

@Nicogene
Copy link
Member Author

I added also the changes of in the iCubGui for using of MAS client since it was a small piece of code.

wholeBodyDynamics, gravityCompensator and iCubGui have now to be tested

@Nicogene Nicogene changed the title Add the MAS client usage in WholeBodyDynamics Add the MAS client usage in WholeBodyDynamics and iCubGui Aug 27, 2019
@Nicogene Nicogene changed the title Add the MAS client usage in WholeBodyDynamics and iCubGui [WIP] Add the MAS client usage in WholeBodyDynamics and iCubGui Aug 27, 2019
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but remember to test it 👍

@pattacini
Copy link
Member

Let's go back to port-wise managing of the inertial done within the iCubGui.
Testing the functionality of WBD can be done via the combined use of ARE and iCubGui.

@Nicogene
Copy link
Member Author

Nicogene commented Sep 3, 2019

In the today meeting, emerged the necessity to connect the iCubGui to the inertial sensor at a later time and test it with the other modules involved in this PR.

TODO:

  • Install the thrift of the MultipleAnalogSensors classes.
  • Remove the instantiation of multipleanalogsensorsclient from iCubGui, it will read form the streaming port measures:o in order to not connect it at start time.
  • Add option in MAS client to connect externally to the streaming port(MultiplAnalogSensorsClient: add --externalConnection option yarp#2098)
  • Test wholeBodyDynamics with ARE
  • Test WBD looking the forces in the iCubGui while moving the arms.

@pattacini
Copy link
Member

@Nicogene any progress on this?

@Nicogene
Copy link
Member Author

This PR depends by robotology/yarp#2098, the minimum yarp version will be bumped.

@Nicogene Nicogene changed the title [WIP] Add the MAS client usage in WholeBodyDynamics and iCubGui [WIP] Add the MAS client usage in WholeBodyDynamics Sep 25, 2019
@Nicogene
Copy link
Member Author

Nicogene commented Oct 8, 2019

The head v2.6 has been handled in this way in iDyn.

I know it is different to how the versioning is handled in iKin, actually iKin is somehow entangled with iDyn.
The best way should be add a constructor that accepts a iKinChain with a specified version in order to use only one versioning system. But for what I understood this library is still used only by few applications.

If I have green light @traversaro and @pattacini I start testing gravityCompensator with the imurfe.

@pattacini
Copy link
Member

🚦 green lights @Nicogene 👍
As said, iDyn is quite old.

@Nicogene Nicogene changed the title [WIP] Add the MAS client usage in WholeBodyDynamics Add the MAS client usage in WholeBodyDynamics Oct 9, 2019
@Nicogene
Copy link
Member Author

Nicogene commented Oct 9, 2019

Today I tested successfully both WBD and gravityCompensator, checking the forces estimated in the iCubGui and trying the compliant mode on the arms.

It worked both with the classic imu and the imurfe.

Ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants