Replace controlboardwrapper2
w/ controlBoard_nws_yarp
#808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove some leftovers after the
controlboardwrapper2
has been declared deprecated in robotology/yarp#2834. The new intended device is thuscontrolBoard_nws_yarp
.In particular,
controlBoard_nws_yarp
does not handle the remapping of the joints as it leverages a specific device for that; instead, the oldcontrolboardwrapper2
was capable of doing remapping as well. As a result,controlBoard_nws_yarp
does not consider the optionAxisMap
.Main components affected:
iCub_SIM
(is deprecated in favor of Gazebo but it still remains a nice-to-have)canBusMotionControl
embObjMotionControl
iCub_SIM
AxisMap
completely removed w/o problems as no remapping was performed at all.robotDescriptionServer
andcontrolBoard_nws_yarp
.canBusMotionControl
,embObjMotionControl
AxisMap
options.