Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace controlboardwrapper2 w/ controlBoard_nws_yarp #808

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

pattacini
Copy link
Member

This PR aims to remove some leftovers after the controlboardwrapper2 has been declared deprecated in robotology/yarp#2834. The new intended device is thuscontrolBoard_nws_yarp.

In particular, controlBoard_nws_yarp does not handle the remapping of the joints as it leverages a specific device for that; instead, the old controlboardwrapper2 was capable of doing remapping as well. As a result, controlBoard_nws_yarp does not consider the option AxisMap.

Main components affected:

  • iCub_SIM (is deprecated in favor of Gazebo but it still remains a nice-to-have)
  • canBusMotionControl
  • embObjMotionControl

iCub_SIM

  • AxisMap completely removed w/o problems as no remapping was performed at all.
  • Still need to verify the interaction between robotDescriptionServer and controlBoard_nws_yarp.
  • Still to be tested.

canBusMotionControl, embObjMotionControl

  • Still handle some AxisMap options.

@pattacini
Copy link
Member Author

iCub_SIM

  • Tests successful
    • ✅ simulator launched ok
    • ✅ moved single joint ok
    • ✅ motor YARP ports' period works ok
  • Still need to verify the interaction between robotDescriptionServer and controlBoard_nws_yarp.

Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at the .cpp and .h inside icubmod/embObjMotionControl and it seems they don't need changes.

@pattacini
Copy link
Member Author

I had a look at the .cpp and .h inside icubmod/embObjMotionControl and it seems they don't need changes.

Thanks heaps @marcoaccame!

@pattacini pattacini marked this pull request as ready for review June 16, 2022 08:47
@pattacini
Copy link
Member Author

Still need to verify the interaction between robotDescriptionServer and controlBoard_nws_yarp.

This is a minor point any how. Everything's working as expected.
Merging.

@pattacini pattacini merged commit 9f1ff37 into master Jun 16, 2022
@pattacini pattacini deleted the fix/cbw2-nws branch June 16, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants