Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frame name for multipleFT sensors #821

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Fix frame name for multipleFT sensors #821

merged 1 commit into from
Sep 14, 2022

Conversation

triccyx
Copy link
Member

@triccyx triccyx commented Sep 9, 2022

Fix frame name for multipleFTSensors
This is the first step done for MultipleFtSensor to understand if this fix is correct @randaz81

@triccyx triccyx closed this Sep 9, 2022
@pattacini pattacini reopened this Sep 9, 2022
@pattacini pattacini marked this pull request as draft September 9, 2022 13:33
@pattacini pattacini requested a review from randaz81 September 9, 2022 13:33
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @triccyx

As discussed, let's extend the fix to the single FT device too.

@triccyx
Copy link
Member Author

triccyx commented Sep 13, 2022

I will create a new PR only for the old FT sensor devices.

@triccyx
Copy link
Member Author

triccyx commented Sep 13, 2022

I have executed the test ao a real sensor without framename in XML the warning appears:
Screenshot from 2022-09-13 12-10-37
The channel plot is correct:
untitled

@triccyx triccyx marked this pull request as ready for review September 13, 2022 10:16
@pattacini
Copy link
Member

Just giving @randaz81 a couple of days for reviewing the PR.
I'm gonna merge it this week.

@randaz81
Copy link
Member

I have the following concern about this multipleFT device (please note that I am not familiar with this device, and I don't know on which robot is currently employed).

  • If this device is handling a single hardware, then its sensor name is unique -> ok
  • if this device provides multiple measurements coming from different points in the space, then probably a list of frame names is required (each frame name then needs to be specified in the urdf file with its coordinates).

@triccyx
Copy link
Member Author

triccyx commented Sep 14, 2022

@randaz81 the result XML section for multiple FT is something like this

  <group name="SENSORS">
                <param name="id">                   l_foot_ft1      l_foot_ft2      l_foot_ft3  </param>
                <param name="board">                strain2         strain2         strain2      </param>
                <param name="location">             CAN2:13         CAN1:13         CAN2:11     </param>
                <param name="framename">            myframename1    myframename2    myframename3 </param>
            </group>

Should it be ok? Each sensor has its own frameName.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

embObjFTsensor: SensorName and SensorFrameName should be different parameters
3 participants