Bump policy_max argument of cmake_minimum_required to 3.28 #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently had problem in compiling icub-main in a conda environment with Python 3.10 installed while the system (Ubuntu 24.04) had Python 3.12 installed. This happened as the old (pre-3.15) behaviour of CMake was to always find the most recent Python version, instead of getting the highest in the path (see https://cmake.org/cmake/help/latest/policy/CMP0094.html).
The problem can be solved without raising the minimum required CMake by setting the
CMP0094policy toNEW, but I think it was good idea to directly raise the policy_max (i.e. the version used for the policies of CMake) argument ofcmake_minimum_requiredto 3.28.