Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icub3: fix realsense urdf exportation #180

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Nov 25, 2020

Use right ini file after adding the head v2.7

It fixes robotology/icub-models#69

@Nicogene Nicogene requested a review from traversaro November 25, 2020 16:40
@Nicogene Nicogene self-assigned this Nov 25, 2020
Copy link
Member

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I think it may be worth to write from where these parameters come from.

@Nicogene Nicogene changed the title icub3: fix realsense urdf exportation [WIP] icub3: fix realsense urdf exportation Nov 25, 2020
@Nicogene
Copy link
Member Author

I still have some issues, first, the frame seems not correct to me

immagine

The camera is looking at the arm.

Moreover, the devices open fine see
immagine

But I still have this error, that I think is a false positive (robotology/gazebo-yarp-plugins#523)

immagine

@Nicogene
Copy link
Member Author

Nicogene commented Dec 1, 2020

Looking to this seems that 97dad07 fixed the rgb and depth frames 🎉

immagine

cc @pattacini @salvi-mattia @traversaro @fiorisi

@Nicogene Nicogene changed the title [WIP] icub3: fix realsense urdf exportation icub3: fix realsense urdf exportation Dec 1, 2020
@Nicogene
Copy link
Member Author

Nicogene commented Dec 1, 2020

Ah I also took the camera parameters from the datasheet

From my side, we can merge it

@traversaro
Copy link
Member

traversaro commented Dec 1, 2020

Ah I also took the camera parameters from the datasheet

Which model of Realsense is mounted in iCub3 and you used for filling the model from the datasheet? In general a reference to a 120 pages document is not really useful in practice. : )

@Nicogene
Copy link
Member Author

Nicogene commented Dec 1, 2020

The model should be the D435, should I write it somewhere in the yaml?

@traversaro
Copy link
Member

The model should be the D435, should I write it somewhere in the yaml?

I think this information is something that should go in the user facing documentation of the iCub3, together with the definition of the frames contained in the model, similar (and better) to what done in iCub2 in https://wiki.icub.org/wiki/ICub_Model_naming_conventions . In the meanwhile, just mentioning it in the PR will ensure that in the future we can find it. Similarly to that, we don't need to document explicitly where the parameters come from for now, but at least explain how they were calculated (for example, where do the values for <center>319.5 239.5</center> or <horizontal_fov>1.57079</horizontal_fov> come from?) in this PR will help future users that may be interested in this info.

@Nicogene
Copy link
Member Author

Nicogene commented Dec 2, 2020

The depth and rgb fov have been taken from the datasheet

immagine

The same for the near plane of the depth

immagine

I didn't find any info about the optical center and I left the one that was defined in the asus_xtion of cer-sim (see https://github.com/robotology/cer-sim/blob/09e3416b5e33b59d85132fe8adff4f239441f4ab/gazebo/cer/cer.sdf#L1424 and https://github.com/robotology/cer-sim/blob/09e3416b5e33b59d85132fe8adff4f239441f4ab/gazebo/cer/cer.sdf#L1455)

They seem to be reasonable for a 640x480 resolution. I think the only way to put it the right values is to ask them to the physical device.

@traversaro
Copy link
Member

Perfect, thanks!

@traversaro traversaro merged commit 0376fc2 into master Dec 2, 2020
@Nicogene Nicogene deleted the fix/icub3Realsense branch December 2, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iCubGazeboV3/iCubGenova09: issues with realsense camera
2 participants