-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
icub3: fix realsense urdf exportation #180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! I think it may be worth to write from where these parameters come from.
I still have some issues, first, the frame seems not correct to me The camera is looking at the arm. Moreover, the devices open fine see But I still have this error, that I think is a false positive (robotology/gazebo-yarp-plugins#523) |
6000498
to
9d2404b
Compare
Use right ini file after adding the head v2.7
9d2404b
to
97dad07
Compare
Looking to this seems that 97dad07 fixed the rgb and depth frames 🎉 |
Ah I also took the camera parameters from the datasheet From my side, we can merge it |
Which model of Realsense is mounted in iCub3 and you used for filling the model from the datasheet? In general a reference to a 120 pages document is not really useful in practice. : ) |
The model should be the |
I think this information is something that should go in the user facing documentation of the iCub3, together with the definition of the frames contained in the model, similar (and better) to what done in iCub2 in https://wiki.icub.org/wiki/ICub_Model_naming_conventions . In the meanwhile, just mentioning it in the PR will ensure that in the future we can find it. Similarly to that, we don't need to document explicitly where the parameters come from for now, but at least explain how they were calculated (for example, where do the values for |
The depth and rgb fov have been taken from the datasheet The same for the near plane of the depth I didn't find any info about the optical center and I left the one that was defined in the They seem to be reasonable for a 640x480 resolution. I think the only way to put it the right values is to ask them to the physical device. |
Perfect, thanks! |
Use right ini file after adding the head v2.7
It fixes robotology/icub-models#69