Align versions of upload/download artifact in Python workflow #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the records, I downloaded manually the artifact containing the wheels and uploaded them manually using |
Then, download and extract all of them in the same folder.
Apparently this is no longer supported: https://github.com/robotology/idyntree/actions/runs/10917334169/job/30300447779 Addressing the problem in 35d845d. |
traversaro
approved these changes
Sep 18, 2024
|
Ok, do you need a 13.0.1 ? |
|
Nope I don't. However I noticed that there still is a problem that I'm going to fix in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this morning that the CI pipeline of a downstream project was failing because it tried to compile from scratch the idyntree wheel starting from its sdist. I realized that yesterday iDynTree 13 was released, and I investigated what happened. It turnes out that PyPI only had the sdist, the wheels were not there, and this is the reason of the failure in the downstream.
The CI/CD pipeline of the tagged release is this one and, as you can notice, there are two different artifacts with the same name. I inspected the Python workflow and I realized that the wheels were uploaded with the v3 action, while the upload of the sdist and the download of the artifact were done with the v4 versions. This was changed recently by a bot PR in #1202.
Probably the different majors are not compatible with each other. In this PR, I aligned all of them. While I'm not sure this solves the problem (I don't exclude a change of behavior in which the artifacts are not merged when multiple jobs try to upload them using the same name), let's keep an eye on it.