Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controlboardwrapper2 deprecation #364

Merged
merged 5 commits into from
Jun 22, 2022
Merged

controlboardwrapper2 deprecation #364

merged 5 commits into from
Jun 22, 2022

Conversation

davidetome
Copy link
Contributor

This PR removes unused files still containing the controlboardwrapper2.
It also modifies :

  • iCubErzelli03
  • iCubGenova03
  • iCubGenova06

These modifications has been tested w/ dry-run and check-nws-nwc-xml

cc @randaz81 @traversaro @Uboldi80 @gsisinna

@davidetome davidetome requested a review from pattacini June 21, 2022 11:12
@davidetome davidetome self-assigned this Jun 21, 2022
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for the iCub* 👍🏻

Just awaiting @randaz81's review for the SN002 (only for what concerns the cleanup of controlboardwrapper2).

@randaz81 randaz81 self-requested a review June 22, 2022 11:23
@pattacini pattacini merged commit 5032862 into robotology:devel Jun 22, 2022
mfussi66 pushed a commit to mfussi66/robots-configuration that referenced this pull request Jun 23, 2022
mfussi66 pushed a commit to mfussi66/robots-configuration that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants