Spawn waist xsensmt standalone and attach it to NWS
#373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicogene
force-pushed
the
feat/waistMAS
branch
from
9777a7c to
f52b617
Compare
|
Today thanks to @HosameldinMohamed I was able to test these changes on iRonCub, I found some small issues that I fixed on all the robot. I think it is ready for merging |
pattacini
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Well done 👍🏻
Let's keep this in review for a few days to give @traversaro the chance to chime in. Otherwise, I'll be happy to merge.
|
Merging anyway. |
It seems fine! It is probably relevant for people mantaining copies/forks of this configuration files, that they may want to get aligned: @gabrielenava @HosameldinMohamed @S-Dafarra @GiulioRomualdi @isorrentino . |
pattacini
changed the title
xsensmt standalone and attach it to the NWS
pattacini
changed the title
xsensmt standalone and attach it to the NWSxsensmt standalone and attach it to NWS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #355
With these changes the
xsensmtdevice of the waist is spawn standalone and then attached by its nws(multipleanalogsensorsserver) and by its deprecated nws(inertial).Please review code.