Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT: replace analogServer (deprecated) with multipleanalogsensorsserver #482

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

Nicogene
Copy link
Member

This has been done both for uniforming with the simulated robots: robotology/icub-models-generator#231 and for the deprecation of analogServer

It fixes #470

To be tested on a robot

@Nicogene Nicogene self-assigned this Apr 18, 2023
@traversaro
Copy link
Member

fyi @GiulioRomualdi @S-Dafarra @gabrielenava this may affect any code that is readying directly from FT sensor ports as a vector.

@traversaro
Copy link
Member

traversaro commented Apr 19, 2023

One thing that we may took the occasion to do know that we do a breaking change is that we could group in a single wrapper all the FT sensors of the leg, for consistency with what we do for other wrappers, such as controlboard.

So, it would be much easier to document which FT sensors are available, i.e. :

For each body part, the available FT and temperature sensors are exposed with a multipleanalogsensorsserver with a prefix /<robotName>/<bodyPart> . If no multipleanalogsensorsserver with a prefix /<robotName>/<bodyPart> is present, no FT or temperature sensors are avalable on that part (for example head or torso as of iCub v2.9).

Instead, in the current situation the ports on which the FT sensors are published are essentially undocumented, complicating the life for users that want to access them. Furthemore, it may be a bit confusing that a multipleanalogsensorsserver that only contains FT sensors and temperature sensors (and no IMU, for example) is published on ports with prefix /<robotName>/<bodyPart>, while for example IMUs (except for xsens's one, but that is another story) are published on /<robotName>/<bodyPart>/inertials.

I know that in general it would be better to do this changes incrementally, but in this case doing several breaking changes may be problematic, so a breaking change in this sense it is a useful opportunity.

@pattacini pattacini force-pushed the FTAnalogServerToMASserver branch from 2b7175e to bfca665 Compare April 19, 2023 09:00
@Nicogene Nicogene force-pushed the FTAnalogServerToMASserver branch from bfca665 to 0837692 Compare April 19, 2023 13:25
@pattacini pattacini force-pushed the FTAnalogServerToMASserver branch from 0837692 to 91b5002 Compare April 19, 2023 13:40
@pattacini
Copy link
Member

rebased on top of the latest devel.
cc @Nicogene

@Nicogene Nicogene force-pushed the FTAnalogServerToMASserver branch from 91b5002 to 417254c Compare April 19, 2023 14:21
@Nicogene
Copy link
Member Author

@traversaro in 417254c (#482) I changed /<robotName>/<bodyPart> to /<robotName>/<bodyPart>/FT, we can think about if we want to introduce also this change or I can revert it.

@Nicogene Nicogene force-pushed the FTAnalogServerToMASserver branch from 417254c to 24570bf Compare April 20, 2023 09:47
@Nicogene Nicogene marked this pull request as ready for review April 20, 2023 09:48
@Nicogene
Copy link
Member Author

After a T2T alignment with @traversaro and @pattacini we decided to proceed merging this PR(it ha been tested on iCubGenova11) and then address

One thing that we may took the occasion to do know that we do a breaking change is that we could group in a single wrapper all the FT sensors of the leg, for consistency with what we do for other wrappers, such as controlboard.

in a second stint; #485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace analogServer with multipleanalogsensorsserver for publishing FT data – Stint 1
3 participants