-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FT: replace analogServer (deprecated) with multipleanalogsensorsserver #482
Conversation
fyi @GiulioRomualdi @S-Dafarra @gabrielenava this may affect any code that is readying directly from FT sensor ports as a vector. |
08ca143
to
50a763a
Compare
50a763a
to
2b7175e
Compare
One thing that we may took the occasion to do know that we do a breaking change is that we could group in a single wrapper all the FT sensors of the leg, for consistency with what we do for other wrappers, such as controlboard. So, it would be much easier to document which FT sensors are available, i.e. :
Instead, in the current situation the ports on which the FT sensors are published are essentially undocumented, complicating the life for users that want to access them. Furthemore, it may be a bit confusing that a I know that in general it would be better to do this changes incrementally, but in this case doing several breaking changes may be problematic, so a breaking change in this sense it is a useful opportunity. |
2b7175e
to
bfca665
Compare
bfca665
to
0837692
Compare
0837692
to
91b5002
Compare
rebased on top of the latest |
91b5002
to
417254c
Compare
@traversaro in |
417254c
to
24570bf
Compare
After a T2T alignment with @traversaro and @pattacini we decided to proceed merging this PR(it ha been tested on
in a second stint; #485 |
This has been done both for uniforming with the simulated robots: robotology/icub-models-generator#231 and for the deprecation of
analogServer
It fixes #470
To be tested on a robot