Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update left arm calibration file for working with calibration type 14 #548

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Jul 25, 2023

This PR brings the following changes:

  • update the configuration values of the calibrator for the open-close finger joints, which works with the new procedure of the calibration type 14 described in the documentation
  • fix the mechanical limits for the rotor

@MSECode MSECode marked this pull request as draft July 25, 2023 08:39
@pattacini
Copy link
Member

Thanks @MSECode 👍🏻

Still in draft because it needs testing on the robot?

@MSECode
Copy link
Contributor Author

MSECode commented Jul 25, 2023

Thanks @MSECode 👍🏻

Still in draft because it needs testing on the robot?

Hi @pattacini,
more or less yes, I've already tested it on the robot but later today I still need to make a couple of checks on ergoCub so let keep it draft until I make the necessary checks.
I'll give you the update here as soon as I'm done.

@sgiraz
Copy link
Contributor

sgiraz commented Jul 26, 2023

Hi @MSECode, can we merge this PR right now?

@MSECode
Copy link
Contributor Author

MSECode commented Jul 26, 2023

Hi @MSECode, can we merge this PR right now?

I'll have a discussion with @valegagge this afternoon about the values of the calibration found yesterday. As soon as we are done we can merge.
I'll update you here.

@sgiraz
Copy link
Contributor

sgiraz commented Jul 26, 2023

Hi @MSECode, can we merge this PR right now?

I'll have a discussion with @valegagge this afternoon about the values of the calibration found yesterday. As soon as we are done we can merge. I'll update you here.

Ok, thanks @MSECode. When you are ready remember to put the PR in Ready for review

@MSECode
Copy link
Contributor Author

MSECode commented Jul 26, 2023

Hi @sgiraz,
after discussion me and @valegagge realized there's a small fix to do on the fw to make the configuration easier to the user.
So we are gonna test it tomorrow and once done that we can update and merge this PR, together with all the others.

@pattacini
Copy link
Member

Thanks for the update @MSECode 👍🏻
Consider also that this PR somehow interacts and blocks #5421, which we need to merge asap.

Footnotes

  1. Probably, because some values ended up in ergoCub 1.0 S/N:000 – align config files with distro 2023.05.02 #542: @sgiraz can be more precise.

…ith calibration type 14

And Update mechanical file with limits
@MSECode MSECode marked this pull request as ready for review July 28, 2023 07:45
@MSECode
Copy link
Contributor Author

MSECode commented Jul 28, 2023

Hi @pattacini,
set the PR as "Ready for Review" after tests on robots.

@pattacini pattacini merged commit 021d8c3 into robotology:devel Jul 28, 2023
@MSECode MSECode deleted the fix/calib14 branch December 28, 2023 13:47
MSECode added a commit to valegagge/robots-configuration that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants