Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed calibrator for CAN device #553

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fixed calibrator for CAN device #553

merged 1 commit into from
Aug 10, 2023

Conversation

davidetome
Copy link
Contributor

This PR fixes the calibrator for CAN devices on these robots :

  • iCubGenova06
  • iCubNancy01

@davidetome davidetome self-assigned this Aug 10, 2023
@davidetome davidetome mentioned this pull request Aug 10, 2023
Closed
7 tasks
@davidetome davidetome requested a review from Nicogene August 10, 2023 09:36
@pattacini pattacini linked an issue Aug 10, 2023 that may be closed by this pull request
Some robots configuration files try to run parametricCalibratorETH on CAN devices, in particular on the head #36
Closed
7 tasks
@pattacini pattacini changed the base branch from devel to master August 10, 2023 09:55
@pattacini pattacini changed the base branch from master to devel August 10, 2023 09:55
pattacini
pattacini approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidetome 👍🏻

pattacini
pattacini requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davidetome

I can still see the use of parametricCalibratorETH on the other parts of the robot iCubNancy01. Could you fix them as well?

Also, given that this is a fix, would you mind rebasing your PR against the upstream master instead of devel?

@davidetome
Copy link
Contributor Author

davidetome commented Aug 10, 2023 •
edited
Loading

Hi @pattacini !

I can still see the use of parametricCalibratorETH on the other parts of the robot iCubNancy01. Could you fix them as well?

The other parts are equipped w/ EMS so I thought that was right to leave Eth , only the head is CAN based.
Isn't it?

Also, given that this is a fix, would you mind rebasing your PR against the upstream master instead of devel?

Sure

@pattacini
Copy link
Member

The other parts are equipped w/ EMS so I thought that was right to leave Eth , only the head is CAN based.
Isn't it?

I don't know actually. I assumed it was a full CAN robot. If you confirm that the other parts are ETH based, that's ok!

@davidetome davidetome changed the base branch from devel to master August 10, 2023 10:16
@pattacini pattacini changed the base branch from master to devel August 10, 2023 10:33
pattacini
pattacini approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just changing the base branch doesn't work as it brings other commits into play. Let me merge this against devel and then cherry-pick it into master.

@pattacini pattacini merged commit 1de1253 into robotology:devel Aug 10, 2023
pattacini pushed a commit that referenced this pull request Aug 10, 2023
@davidetome @pattacini
fixed calibrator for CAN device (#553)
e68cdfb
MSECode pushed a commit to valegagge/robots-configuration that referenced this pull request Apr 11, 2024
@davidetome @valegagge
fixed calibrator for CAN device (robotology#553)
fd51b3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattacini pattacini pattacini approved these changes

@traversaro traversaro Awaiting requested review from traversaro

@Nicogene Nicogene Awaiting requested review from Nicogene

Assignees

@davidetome davidetome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some robots configuration files try to run parametricCalibratorETH on CAN devices, in particular on the head
2 participants
@davidetome @pattacini