-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ergoCubSN001 002- update network file #652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @davidetome
Could you provide some insights underlying this big change?
Also, would it be worth covering the other ergoCub as well?
Possibly, there's one typo requiring attention. Didn't spot others but, please, check it.
Ciao @pattacini !!! I noticed that the network file was not aligned to the real architecture , I just fixed some errors w/ the last commit today and checked again w/ the schematic. Also SN002 is not correct (probably copied when the folder was created) |
Superb! Thanks heaps!
Then, it'd be great if we could fix it up as well. @AntonioConsilvio, you may consider checking these things out for SN000, which is by us these days. |
@pattacini @AntonioConsilvio , as suggested by @valegagge , I also fixed SN002 with the last commit 👍🏼 |
Thanks @davidetome 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awaiting the PR to be put in ready for review.
Hi! Well done @davidetome. I'd just like to add that some boards are actually not connected to each other. For example, the Other boards might have this little problem, in the architecture the ETH switch is represented like this: cc @pattacini |
ciao @AntonioConsilvio , it doesn't matter...the previous and next tag are only for info when reading the file. cc @pattacini |
@AntonioConsilvio , just to make you happy I just fixed them with the last commit 😄 👍🏼 |
…ergoCubSN001 and ergoCubSN002
as suggested by @valegagge I added the network files for 2foc update for ergoCubSN001 and ergoCubSN002 used to change their FW for demos (AMI req) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates the network file of the robots ergoCub SN001 and ergoCubSN002
cc @valegagge