Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ergoCubSN001 002- update network file #652

Merged
merged 8 commits into from
May 24, 2024
Merged

Conversation

davidetome
Copy link
Contributor

@davidetome davidetome commented May 16, 2024

This PR updates the network file of the robots ergoCub SN001 and ergoCubSN002

cc @valegagge

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davidetome

Could you provide some insights underlying this big change?
Also, would it be worth covering the other ergoCub as well?

Possibly, there's one typo requiring attention. Didn't spot others but, please, check it.

ergoCubSN001/network.ergoCubSN001.xml Outdated Show resolved Hide resolved
@valegagge valegagge marked this pull request as draft May 16, 2024 20:03
@davidetome
Copy link
Contributor Author

davidetome commented May 17, 2024

Hi @davidetome

Could you provide some insights underlying this big change? Also, would it be worth covering the other ergoCub as well?

Possibly, there's one typo requiring attention. Didn't spot others but, please, check it.

Ciao @pattacini !!!

I noticed that the network file was not aligned to the real architecture ,

I just fixed some errors w/ the last commit today and checked again w/ the schematic.

Also SN002 is not correct (probably copied when the folder was created)

cc @valegagge @AntonioConsilvio

@pattacini
Copy link
Member

I noticed that the network file was not aligned to the real architecture ,

I just fixed some errors and checked again w/ the schematic.

Superb! Thanks heaps!

Also SN002 is not correct (probably copied when the folder was created)

Then, it'd be great if we could fix it up as well.

@AntonioConsilvio, you may consider checking these things out for SN000, which is by us these days.

@davidetome
Copy link
Contributor Author

@pattacini @AntonioConsilvio , as suggested by @valegagge , I also fixed SN002 with the last commit 👍🏼

@pattacini
Copy link
Member

Thanks @davidetome 🚀

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting the PR to be put in ready for review.

@AntonioConsilvio
Copy link
Contributor

AntonioConsilvio commented May 17, 2024

Hi! Well done @davidetome.

I'd just like to add that some boards are actually not connected to each other.

For example, the 10.0.1.2 board, has no boards before it, because it's connected to the ETH switch (Gigablox) so it might make sense to edit line 66 in exactly the same way as 10.0.1.5 (i.e. without the prev parameter - line 266)?
Similarly, 10.0.1.21 has no boards after it, so it might make sense to remove the next parameter (line 56)?

Other boards might have this little problem, in the architecture the ETH switch is represented like this:

image

cc @pattacini

@davidetome
Copy link
Contributor Author

davidetome commented May 17, 2024

Hi! Well done @davidetome.

I'd just like to add that some boards are actually not connected to each other.

For example, the 10.0.1.2 board, has no boards before it, because it's connected to the ETH switch (Gigablox) so it might make sense to edit line 66 in exactly the same way as 10.0.1.5 (i.e. without the prev parameter - line 266)? Similarly, 10.0.1.21 has no boards after it, so it might make sense to remove the next parameter (line 56)?

Other boards might have this little problem, in the architecture the ETH switch is represented like this:

image

cc @pattacini

ciao @AntonioConsilvio , it doesn't matter...the previous and next tag are only for info when reading the file.
you can also not declare them and the script runs the same

cc @pattacini

@davidetome
Copy link
Contributor Author

@AntonioConsilvio , just to make you happy I just fixed them with the last commit 😄 👍🏼

@davidetome
Copy link
Contributor Author

as suggested by @valegagge I added the network files for 2foc update for ergoCubSN001 and ergoCubSN002 used to change their FW for demos (AMI req)

Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valegagge valegagge marked this pull request as ready for review May 22, 2024 20:03
@pattacini pattacini merged commit 4ed3bf6 into robotology:devel May 24, 2024
2 checks passed
@davidetome davidetome changed the title ergoCubSN001 - update network file ergoCubSN001 002- update network file May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants