-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility to use the walking-module with iCubGenova09 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiulioRomualdi
changed the title
Add the possibility to use the walking-module with iCUbGenova09
Add the possibility to use the walking-module with iCubGenova09
Feb 5, 2021
GiulioRomualdi
force-pushed
the
test/icub3_with_wbd
branch
4 times, most recently
from
February 5, 2021 16:11
686fda9
to
e7d635f
Compare
The PR is ready to be reviewed |
GiulioRomualdi
commented
Feb 13, 2021
@@ -6,7 +6,7 @@ right_foot_frame r_sole | |||
left_hand_frame l_hand_dh_frame | |||
right_hand_frame r_hand_dh_frame | |||
|
|||
head_frame imu_frame | |||
head_frame head |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@S-Dafarra this is the reason why you had the problem today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the modification! Now everything should work
GiulioRomualdi
force-pushed
the
test/icub3_with_wbd
branch
from
February 15, 2021 09:41
6749d72
to
d7b465c
Compare
S-Dafarra
approved these changes
Mar 4, 2021
Increased the shoulder rolls to avoid hitting the legs with the arms. Increased the gains for retargeting.
…to the latest version of the Library
GiulioRomualdi
force-pushed
the
test/icub3_with_wbd
branch
from
March 4, 2021 15:56
d7b465c
to
fe9b999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.