Remove six #344
Merged
Remove six #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavier-contreras
approved these changes
Mar 7, 2024
JoseIgnacioTamayo
force-pushed
the
remove_py2
branch
from
a06c3c3 to
d6c3483
Compare
|
I would like to get some opinions for this change. Python2 is gone, and we can stop using six as the code works on Python3. Of course, this breaks Python2... which might be OK to break? |
|
IMO this is fine. Developer survey shows less than 7% still using python2 in 2022. I'd expect this to be lower now, see second link. https://lp.jetbrains.com/python-developers-survey-2022/#PythonVersions https://www.jetbrains.com/lp/devecosystem-2023/python/ (this shows 1%) |
The supported PythonVersion is PY3.
JoseIgnacioTamayo
force-pushed
the
remove_py2
branch
from
d2cbb55 to
9aa7e59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because there is only Python3 now