Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename albatross-client-local to albatross-local #162

Merged
merged 12 commits into from
May 5, 2023
Merged

rename albatross-client-local to albatross-local #162

merged 12 commits into from
May 5, 2023

Conversation

hannesm
Copy link
Collaborator

@hannesm hannesm commented Apr 11, 2023

rename albatross-client-bistro to albatross-remote
merge albatross-client-remote-tls into albatross-remote as "certificate" subcommand

also get rid of fail_with

once this is in, we should (a) test (b) cut a 2.0 (c) update the documents that refer to albatross commands... what do you think @reynir?

@hannesm
Copy link
Collaborator Author

hannesm commented Apr 11, 2023

not sure, but albatross-local includes a tls stack etc. for "update" -- so what about merging all that even further into a single albatross-client binary which can do local or remote stuff, and may even include the albatross-provision parts
--> all the albatross commands would only exist once (easy to update / reason) --> less code duplication
-> the logic whether to dump to a file (provision), interact with albatross locally (albatross-client-local) or remotely (albatross-client-bistro) would be as a matter of "destination" parameters
-> only some subcommands would be special (such as inspect-dump / generate-ca / sign-csr / certificate) since they only have a specific use environment.

what do you think?

hannesm added 2 commits May 3, 2023 12:38
@hannesm
rename albatross-client-local to albatross-local
65b75af 
rename albatross-client-bistro to albatross-remote
 merge albatross-client-remote-tls into albatross-remote as "certificate" subcommand

also get rid of fail_with
@hannesm
merge all the clients
0993865
@hannesm
Copy link
Collaborator Author

hannesm commented May 3, 2023

now everything is merged, this should be good to be reviewed and tested :) //cc @reynir

@hannesm hannesm merged commit 8b13eee into main May 5, 2023
@hannesm hannesm deleted the merge-clients branch May 5, 2023 13:20
@hannesm hannesm mentioned this pull request May 14, 2023
Merged
hannesm added a commit to hannesm/opam-repository that referenced this pull request May 14, 2023
@hannesm
[new release] albatross (2.0.0)
409e9c2 
CHANGES:

This is a breaking release since the binaries to be installed have been revised
and merged. The `albatross-client-local` is now `albatross-client [--socket]`,
`albatross-provision-ca` is now `albatross-client sign` or `albatross-client
generate`. The `albatross-client-remote` is now `albatross-client certificate`.
The `albatross-client-bistro` is now `albatross-client <command>
--destination <host> --ca ca.pem --ca-key ca.pem --server-ca cacert.pem`.

And finally, `albatross-tls-inetd` is now `albatross-tls-endpoint --inetd`.

- Document TLS usage (robur-coop/albatross#155, robur-coop/albatross#156 @TheLortex @hannesm)
- Improve TLS experience by providing more reasonable error messages and apply
  more checks before establishing a TLS session (robur-coop/albatross#157 @hannesm @reynir)
- Slim down binaries:
  - remove albatross-stat-client binary (robur-coop/albatross#161 @hannesm)
  - move X509 parts out of Albatross_cli (robur-coop/albatross#158 @reynir)
  - merge albatross-tls-inetd with albatross-tls-endpoint (robur-coop/albatross#160 @hannesm)
  - merge albatross-client-inspect-dump into albatross-client (robur-coop/albatross#161 @hannesm)
  - merge albatross-provision-ca and albatross-provision-request into
    albatross-client (robur-coop/albatross#159 @reynir @hannesm)
  - merge albatross-client-remote and albatross-client-bistro and
    albatross-client-local into albatross-client (robur-coop/albatross#162 @hannesm)
- Check solo5 ABI tender version, allow multiple solo5 tenders to exist (named
  as solo5-{s,h}vt.<ABI> (robur-coop/albatross#163 @hannesm)
- Improve documentation and manpages (robur-coop/albatross#164 @hannesm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hannesm