Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

record start timestamp and provide via info (fixes #168) #169

Merged
merged 2 commits into from
Dec 4, 2023
Merged

record start timestamp and provide via info (fixes #168) #169

merged 2 commits into from
Dec 4, 2023

Conversation

hannesm
Copy link
Collaborator

@hannesm hannesm commented Dec 4, 2023

//cc @reynir

hannesm
hannesm commented Dec 4, 2023
View reviewed changes
src/vmm_asn.ml
@@ -644,7 +645,8 @@ let unikernel_info =
(required ~label:"net-name" utf8_string)
(optional ~label:"bridge-name" utf8_string)
(optional ~label:"mac" mac_addr)))))
-@ (optional ~label:"arguments"(my_explicit 2 (sequence_of utf8_string))))
@ (optional ~label:"arguments"(my_explicit 2 (sequence_of utf8_string)))
-@ (optional ~label:"started" (my_explicit 3 generalized_time)))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is optional, old servers will be able to communicate with new clients. new servers will emit that and may make old clients fail...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is acceptable. It is usually easier to upgrade the client than the server.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, but then we may have no control over the client installations when we upgrade the server. I added the bit needed in 2aef890.

reynir
reynir approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@reynir reynir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hannesm
allow old clients to talk to new servers (they will send the old_unik…
2aef890 
…ernel_info2 and receive an old_unikernel_info)
@reynir reynir linked an issue Dec 4, 2023 that may be closed by this pull request
Record start time and report it in albatross-client info #168
Closed
@hannesm
Copy link
Collaborator Author

hannesm commented Dec 4, 2023

Now, certainly a new client will request the new unikernel_info command, and an old server may just fail to understand the meaning. This is fine, as written in vmm_asn, it may be worth to work on a --use-version or --old-version for the client, or even have a negotiation mechanism between client and server on startup.

For now, I'd merge this PR; for albatross 3 we can rethink the command negotiation mechanism.

@hannesm hannesm merged commit 24301be into main Dec 4, 2023
@hannesm hannesm deleted the record-started branch December 4, 2023 14:07
hannesm added a commit to hannesm/opam-repository that referenced this pull request Aug 15, 2024
@hannesm
[new release] albatross (2.1.0)
67875ad 
CHANGES:

* BUGFIX install tls_endpoint as systemd service (not only as example), fix typo
  (robur-coop/albatross#183 @PizieDust)
* BUGFIX albatross-influx: use "cow_faults" (fixed typo in robur-coop/albatross#182) as unsigned
  integer (b9695dd9c267f5e59f18154a632adba0481f9d72, @hannesm)
* BUGFIX albatross-influx: avoid empty measurement (robur-coop/albatross#182 @hannesm)
* BUGFIX tls-endpoint: don't fail if a bad client connects (robur-coop/albatross#180 @hannesm)
* FEATURE tls-endpoint: add syslog support (esp. useful for inetd) (robur-coop/albatross#185 @hannesm)
* FEATURE Update to FreeBSD 14 (robur-coop/albatross#172, @hannesm)
* BUGFIX update command: make usable with local client (robur-coop/albatross#184, @reynir)
* BUGFIX update command: handle HTTP not found explicitly
  (fixes robur-coop/albatross#147, robur-coop/albatross#171 @hannesm)
* FEATURE Albatross: record start timestamp via info (fixes robur-coop/albatross#168, robur-coop/albatross#169 @hannesm)
* BUGFIX Albatross: store timestamp as generalized time instead of utc time
  (robur-coop/albatross#167 @hannesm @reynir, adjusted by robur-coop/albatross#181 for backwards compatibility
   @PizieDust)
* BUGFIX FreeBSD: restart services when they terminate
  (@hannesm, 64f28fbd88504ec33d6bfde5211684e0ba1bc193)
* BUGFIX packaging: install albatross-client as albatross-client
  (@hannesm, 23acb8b3edbe0153e1bd24a1736b80e73a27e33f)
* update nix inputs (robur-coop/albatross#175, robur-coop/albatross#179 @Julow)
* use ohex instead of hex (robur-coop/albatross#174 @hannesm)
* fix README (robur-coop/albatross#177 @PizieDust, 2a1c3d898b586946ce7c4f3171ea5eb856f4ade8,
  107c235eb94e83d6a077c42ee8b527c207af4ba7)
@hannesm hannesm mentioned this pull request Aug 15, 2024
Merged
avsm pushed a commit to avsm/opam-repository that referenced this pull request Sep 5, 2024
@hannesm @avsm
[new release] albatross (2.1.0)
63aae0c 
CHANGES:

* BUGFIX install tls_endpoint as systemd service (not only as example), fix typo
  (robur-coop/albatross#183 @PizieDust)
* BUGFIX albatross-influx: use "cow_faults" (fixed typo in robur-coop/albatross#182) as unsigned
  integer (b9695dd9c267f5e59f18154a632adba0481f9d72, @hannesm)
* BUGFIX albatross-influx: avoid empty measurement (robur-coop/albatross#182 @hannesm)
* BUGFIX tls-endpoint: don't fail if a bad client connects (robur-coop/albatross#180 @hannesm)
* FEATURE tls-endpoint: add syslog support (esp. useful for inetd) (robur-coop/albatross#185 @hannesm)
* FEATURE Update to FreeBSD 14 (robur-coop/albatross#172, @hannesm)
* BUGFIX update command: make usable with local client (robur-coop/albatross#184, @reynir)
* BUGFIX update command: handle HTTP not found explicitly
  (fixes robur-coop/albatross#147, robur-coop/albatross#171 @hannesm)
* FEATURE Albatross: record start timestamp via info (fixes robur-coop/albatross#168, robur-coop/albatross#169 @hannesm)
* BUGFIX Albatross: store timestamp as generalized time instead of utc time
  (robur-coop/albatross#167 @hannesm @reynir, adjusted by robur-coop/albatross#181 for backwards compatibility
   @PizieDust)
* BUGFIX FreeBSD: restart services when they terminate
  (@hannesm, 64f28fbd88504ec33d6bfde5211684e0ba1bc193)
* BUGFIX packaging: install albatross-client as albatross-client
  (@hannesm, 23acb8b3edbe0153e1bd24a1736b80e73a27e33f)
* update nix inputs (robur-coop/albatross#175, robur-coop/albatross#179 @Julow)
* use ohex instead of hex (robur-coop/albatross#174 @hannesm)
* fix README (robur-coop/albatross#177 @PizieDust, 2a1c3d898b586946ce7c4f3171ea5eb856f4ade8,
  107c235eb94e83d6a077c42ee8b527c207af4ba7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reynir reynir reynir approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Record start time and report it in albatross-client info
2 participants
@hannesm @reynir