Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor into reusable crates #287

Merged
merged 6 commits into from
Dec 14, 2024
Merged

Refactor into reusable crates #287

merged 6 commits into from
Dec 14, 2024

Conversation

lukewilliamboswell
Copy link
Collaborator

@lukewilliamboswell lukewilliamboswell commented Dec 14, 2024

Refactor common logic into reusable crates, so these can be shared with roc-lang/basic-webserver or any roc based platforms that wish to provide the same API and implementation.

Added some cargo docs to help use these crates.

Screenshot 2024-12-14 at 16 09 59

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reordering as I separate into crates, wanting to find good commonality / reusability with basic-webserver. There are no API changes in this PR.

@lukewilliamboswell lukewilliamboswell changed the title [WIP] refactor into reusable crates Refactor into reusable crates Dec 14, 2024
@lukewilliamboswell lukewilliamboswell marked this pull request as ready for review December 14, 2024 05:27
@lukewilliamboswell lukewilliamboswell merged commit fbdd5e6 into main Dec 14, 2024
5 checks passed
@lukewilliamboswell lukewilliamboswell deleted the refactor branch December 14, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants