Port updates from basic-webserver & basic-ssg upgrades, fix PR comments
#290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewilliamboswell
changed the title
basic-webserver & basic-ssg upgrades, fix PR comments
smores56
previously approved these changes
Dec 18, 2024
| query_params : Url -> Dict Str Str | ||
| query_params = \url -> | ||
| query url | ||
| |> Str.splitOn "&" |
There was a problem hiding this comment.
Might want to handle trailing & by removing empty strings? Not that important, I expect there will be some Url lib someday that properly handles this stuff.
| @@ -85,3 +86,11 @@ get! = \uri, fmt -> | |||
|
|
|||
| Decode.fromBytes response.body fmt | |||
| |> Result.mapErr \_ -> HttpDecodingFailed | |||
|
|
|||
| get_utf8! : Str => Result Str [BadBody Str] | |||
There was a problem hiding this comment.
It doesn't seem like we have this error union anymore for errors, so we should maybe provide an error tag because it's lower cardinality? I'd vote [InvalidUtf8Body] instead.
|
Apparently we need to update gcc on the ci machines |
lukewilliamboswell
force-pushed
the
refactor
branch
from
a0b40fe to
349a499
Compare
smores56
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.