Add Sqlite to basic-cli #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhansconnect
commented
Dec 29, 2024
lukewilliamboswell
previously approved these changes
Dec 29, 2024
|
I think this is good to merge! |
|
|
|
I caught up on the zulip conversation and the successful test 👍 |
This reverts commit 80a8577.
lukewilliamboswell
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a direct port of what was in basic-webserver. Just converted to purity inference and separated into it's own crate. The example will not work correctly until roc-lang/roc#7427 lands in the roc repo.
I'm hoping that switching to
libsqlite3-syswill fix our bundling issues. If not, we can switch back to the linked version ofsqlite3-sys. They both have 100% compatible apis.