Add More Tests #313
Merged
Add More Tests #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phalestrivir I merged the first two PRs in lib and cli, would you be able to rebase and update this PR? |
@vscheuber Yes, I can rebase and update it, although I won't be able to get to it until tomorrow (Friday) afternoon. I'll let you know once it's updated and ready to go. |
…date and add tests for these operations.
phalestrivir
force-pushed
the
feature/tests
branch
from
843941e to
31e01f6
Compare
|
@vscheuber I just rebased this PR, so it should all be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some more tests to the CLI that were missing, and fixes some bugs that were found while creating them. There are a couple of tests that are currently being skipped: some delete tests do not have mocks for the -a --all option yet (since this involves deleting a lot of data) and for the esv-secret-create op there is currently no way of creating secrets encoded with pem or base64hmac, so these tests are skipped for now. There are no changes to the frodo-lib for this PR.