Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: An error would occur starting the smartnode when alerting was enabled but metrics was not #509

Merged

Conversation

activescott
Copy link
Contributor

When enabling alerting in the TUI but not enabling Metrics, the following error would occur starting smartnode:

$ ./rp-run.sh s start

Validator client [lodestar] was previously used - no slashing prevention delay necessary.
[+] Running 8/8
 ✔ Container rocketpool_alertmanager  Created                                                                                                             0.0s 
 ✔ Container rocketpool_addon_gww     Started                                                                                                             0.0s 
 ✔ Container rocketpool_watchtower    Started                                                                                                             0.0s 
 ✔ Container rocketpool_eth2          Started                                                                                                             0.0s 
 ✔ Container rocketpool_eth1          Started                                                                                                             0.0s 
 ✔ Container rocketpool_api           Started                                                                                                             0.0s 
 ✔ Container rocketpool_node          Started                                                                                                             0.0s 
 ✔ Container rocketpool_validator     Started                                                                                                             0.0s 
Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error mounting "/home/scott/.rocketpool/alerting/alertmanager.yml" to rootfs at "/etc/alertmanager/alertmanager.yml": mount /home/scott/.rocketpool/alerting/alertmanager.yml:/etc/alertmanager/alertmanager.yml (via /proc/self/fd/6), flags: 0x5000: not a directory: unknown: Are you trying to mount a directory onto a file (or vice-versa)? Check if the specified host path exists and is the expected type
exit status 1
exit status 1

Doing the same command to start it with the same config after this fix:

scott@debprime (master *): ~/src/rocket-pool/smartnode$ ./rp-run.sh s start

Validator client [lodestar] was previously used - no slashing prevention delay necessary.
[+] Running 8/8
 ✔ Container rocketpool_node          Started                                                                                                             0.0s 
 ✔ Container rocketpool_alertmanager  Started                                                                                                             0.0s 
 ✔ Container rocketpool_addon_gww     Started                                                                                                             0.0s 
 ✔ Container rocketpool_eth2          Started                                                                                                             0.0s 
 ✔ Container rocketpool_eth1          Started                                                                                                             0.0s 
 ✔ Container rocketpool_api           Started                                                                                                             0.0s 
 ✔ Container rocketpool_watchtower    Started                                                                                                             0.0s 
 ✔ Container rocketpool_validator     Started                                                                                                             0.0s 

This was uncovered in the support channel at https://discord.com/channels/405159462932971535/468923220607762485/1232740280067948695

@activescott
Copy link
Contributor Author

Tests! I love it! Go @jshufro !

@jclapis
Copy link
Member

jclapis commented Apr 25, 2024

Thank you!

@jclapis jclapis merged commit cf91b5a into rocket-pool:master Apr 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants