Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In place cleanup of several abstractions #17

Merged
merged 2 commits into from
Oct 25, 2023
Merged

In place cleanup of several abstractions #17

merged 2 commits into from
Oct 25, 2023

Conversation

ari-e
Copy link
Contributor

@ari-e ari-e commented Oct 24, 2023

Some unrelated cleanups. None of these should affect the logic of the connector.

Changes include:

  • Simplify RocksetRequestWrapper error handling and unify its constructors
  • Remove unneeded getters from RocksetConnectorConfig for deprecated fields
  • Add explicit open() and close() overrides for RocksetSinkTask
  • Move all parsers into a new package rockset.parser
  • More consistent logging in several places

@ari-e ari-e changed the base branch from master to ari_remove-client-wrapper October 24, 2023 18:32
@ari-e ari-e force-pushed the ari_remove-client-wrapper branch from fcb9c0a to af59208 Compare October 24, 2023 20:24
@ari-e ari-e force-pushed the ari_cleanup branch 2 times, most recently from 3c70725 to 05bb18d Compare October 24, 2023 20:45
@ari-e ari-e requested a review from kwadhwa18 October 25, 2023 00:37
@ari-e ari-e merged commit 05c8a27 into ari_remove-client-wrapper Oct 25, 2023
1 check passed
@ari-e ari-e mentioned this pull request Oct 30, 2023
Merged
ari-e added a commit that referenced this pull request Oct 30, 2023
@ari-e
Merge #16 and #17 to master
e685ce4 
#16 and #17 accidentally got squashed into other branches. This correctly merges them to master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwadhwa18 kwadhwa18 kwadhwa18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ari-e @kwadhwa18