Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new wait method and moar tests #72

Merged
merged 1 commit into from
Oct 28, 2022
Merged

new wait method and moar tests #72

merged 1 commit into from
Oct 28, 2022

Conversation

pmenglund
Copy link
Member

terraform provider needs to be able to wait for an alias to be gone so
it can clean up the workspace

@pmenglund
Copy link
Member Author

pmenglund commented Oct 28, 2022 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@pmenglund pmenglund requested a review from a team October 28, 2022 20:11
@pmenglund pmenglund marked this pull request as ready for review October 28, 2022 20:11
@pmenglund pmenglund mentioned this pull request Oct 28, 2022
Merged
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 375

  • 35 of 44 (79.55%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.7%) to 50.095%
Changes Missing Coverage Covered Lines Changed/Added Lines %
wait.go 35 44 79.55%
Files with Coverage Reduction New Missed Lines %
ha.go 4 88.71%
Totals Coverage Status
Change from base Build 373: 0.7%
Covered Lines: 1313
Relevant Lines: 2621
💛 - Coveralls

@pmenglund pmenglund merged commit bf802f0 into master Oct 28, 2022
@pmenglund pmenglund deleted the pme/wait branch October 28, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morganda morganda morganda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmenglund @coveralls @morganda