Ensure that we are dereferencing elements that exists #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganda
approved these changes
Nov 10, 2023
Oups will fix lint. |
Summary We were derefencing variables that could be nil. For instance if the query don't return an error but just no lines then doing err.Error() was causing a nil/null derefencing. Similarly if the field array in the frame was has only one element doing ``` frame.Fields[1].Len() ``` Would result in a crash because we would derefence a nil pointer. We are fixing this here. Also we are returning a nicer message when the query results are empty. Testing Used a query that is returning no line, before the change this would crash the plug-in after the change it's printing a nice(r) message about the fact that the query is not returning lines.
mpatou
force-pushed
the
fix_plugin_crashes
branch
from
b27b78f to
15f86e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were derefencing variables that could be nil.
For instance if the query don't return an error but just no lines then
doing err.Error() was causing a nil/null derefencing.
Similarly if the field array in the frame was has only one element doing
Would result in a crash because we would derefence a nil pointer.
We are fixing this here. Also we are returning a nicer message when the
query results are empty.
Testing
Used a query that is returning no line, before the change this would
crash the plug-in after the change it's printing a nice(r) message
about the fact that the query is not returning lines.