EOL mount_refresh_interval (#80)

rockset · Oct 18, 2023 · 4560b4b · 4560b4b
1 parent d98acf3
commit 4560b4b
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 24 deletions.
diff --git a/docs/data-sources/virtual_instance.md b/docs/data-sources/virtual_instance.md
@@ -27,6 +27,5 @@ description: |-
 - `description` (String) Virtual Instance description.
 - `desired_size` (String) Virtual Instance desired size.
 - `enable_remount_on_resume` (Boolean) When a Virtual Instance is resumed, it will remount all collections that were mounted when the Virtual Instance was suspended.
-- `mount_refresh_interval_seconds` (Number) Number of seconds between data refreshes for mounts on this Virtual Instance.
 - `name` (String) Virtual Instance name.
 - `state` (String) Virtual Instance state.
diff --git a/docs/resources/mongodb_collection.md b/docs/resources/mongodb_collection.md
@@ -49,6 +49,11 @@ Required:
 - `database_name` (String) MongoDB database name containing the target collection.
 - `integration_name` (String) The name of the Rockset MongoDB integration.
 
+Optional:
+
+- `retrieve_full_document` (Boolean) Whether to get the full document from the MongoDB change stream to enable multi-field expression transformations.
+Selecting this option will increase load on your upstream MongoDB database.
+
 Read-Only:
 
 - `scan_end_time` (String) MongoDB scan end time.

diff --git a/docs/resources/virtual_instance.md b/docs/resources/virtual_instance.md
@@ -42,7 +42,6 @@ resource "rockset_collection_mount" "patch" {
 
 - `auto_suspend_seconds` (Number) Number of seconds without queries after which the Virtual Instance is suspended.
 - `description` (String) Description of the virtual instance.
-- `mount_refresh_interval_seconds` (Number) Number of seconds between data refreshes for mounts on this Virtual Instance. A value of 0 means continuous refresh and a value of null means never refresh.
 - `remount_on_resume` (Boolean) When a Virtual Instance is resumed, remount all collections that were mounted when the Virtual Instance was suspended.
 
 ### Read-Only

diff --git a/rockset/data_source_virtual_instance.go b/rockset/data_source_virtual_instance.go
@@ -59,11 +59,6 @@ func dataSourceRocksetVirtualInstance() *schema.Resource {
 				Type:        schema.TypeBool,
 				Optional:    true,
 			},
-			"mount_refresh_interval_seconds": {
-				Description: "Number of seconds between data refreshes for mounts on this Virtual Instance.",
-				Type:        schema.TypeInt,
-				Optional:    true,
-			},
 			// TODO: auto_scaling_policy
 		}}
 }
@@ -103,9 +98,6 @@ func dataSourceReadRocksetVirtualInstance(ctx context.Context, d *schema.Resourc
 	if err = d.Set("enable_remount_on_resume", vi.GetEnableRemountOnResume()); err != nil {
 		return diag.FromErr(err)
 	}
-	if err = d.Set("mount_refresh_interval_seconds", vi.GetMountRefreshIntervalSeconds()); err != nil {
-		return diag.FromErr(err)
-	}
 
 	d.SetId(id)
 

diff --git a/rockset/data_source_virtual_instance_test.go b/rockset/data_source_virtual_instance_test.go
@@ -24,7 +24,6 @@ func TestAccVirtualInstance_Data(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "default", "true"),
 					resource.TestCheckResourceAttr(resourceName, "state", "ACTIVE"),
 					resource.TestCheckResourceAttr(resourceName, "enable_remount_on_resume", "false"),
-					resource.TestCheckResourceAttr(resourceName, "mount_refresh_interval_seconds", "0"),
 				),
 			},
 		},

diff --git a/rockset/resource_virtual_instance.go b/rockset/resource_virtual_instance.go
@@ -78,11 +78,6 @@ which must be SMALL or larger. To enable live mount, the secondary virtual insta
 				Optional:     true,
 				ValidateFunc: validation.IntAtLeast(900),
 			},
-			"mount_refresh_interval_seconds": {
-				Description: "Number of seconds between data refreshes for mounts on this Virtual Instance. A value of 0 means continuous refresh and a value of null means never refresh.",
-				Type:        schema.TypeInt,
-				Optional:    true,
-			},
 			"state": {
 				Description: "Virtual Instance state.",
 				Type:        schema.TypeString,
@@ -223,11 +218,6 @@ func getVirtualInstanceOptions(d *schema.ResourceData) []option.VirtualInstanceO
 	addOptionIfChanged(d, "remount_on_resume", &options, func(a any) option.VirtualInstanceOption {
 		return option.WithRemountOnResume(a.(bool))
 	})
-	addOptionIfChanged(d, "mount_refresh_interval_seconds", &options, func(a any) option.VirtualInstanceOption {
-		// option.WithNoMountRefresh()
-		seconds := time.Duration(a.(int)) * time.Second
-		return option.WithMountRefreshInterval(seconds)
-	})
 
 	return options
 }
@@ -254,9 +244,6 @@ func parseVirtualInstanceFields(vi openapi.VirtualInstance, d *schema.ResourceDa
 	if err := setValue(d, "auto_suspend_seconds", vi.GetAutoSuspendSecondsOk); err != nil {
 		return err
 	}
-	if err := setValue(d, "mount_refresh_interval_seconds", vi.GetMountRefreshIntervalSecondsOk); err != nil {
-		return err
-	}
 	if err := setValue(d, "state", vi.GetStateOk); err != nil {
 		return err
 	}