Issue#1503 migrating gevent socketio to python socketio #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernel_error - ad hoc func exists -, plus code cleaning
Adding listener to namespace_event instead of namespace:event (not required) Removing listener (disconnect) now doesn't require socket.disconnect
…ing on namespaces/events
… we handle new socket.io connections
…full python-socketio. Main has IMPORTANT notes for everyone coding new namespaces/events
Hi @schakrava, this commit saves us from having infinite emitters on services page. While checking that glitch on modal views realized that on every page refresh had services updates getting faster so had a check on data_collector and found this. Curious to see how this will affect our Rockstor :) Signed-off-by: Mirko Arena <[email protected]>
|
Nicely done @MFlyer . Removing gevent-socketio has been on my list for sometime now and I am glad you beat me to it. |
MFlyer
deleted the
issue#1503_Migrating_gevent-socketio_to_python-socketio
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1503
Hi @schakrava,
this PR is ready for review / to be merged.
Had some tests on every module using socketio (dashboard widgets, pincard, logs manager and services) and all seem fine, pls have some test again and confirm :)
Other useful infos:
This PR requires rockstor/rockstor-jslibs#9 to be merged (js libs update, socket io to latest 1.5.1 😃 )
Mirko