[serlib] Fix segfault in univs.ml #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this pull request
Aug 26, 2020
CHANGES: * [general] Require dune >= 2.0 (@ejgallego, ??) * [serapi] New query `Comments` to return all comments in a document (@ejgallego, rocq-archive/coq-serapi#20? , (partially) fixes rocq-archive/coq-serapi#191 , ejgallego/coq-serapi#200 ) * [general] Coq's error recovery is now disabled by default (@ejgallego , fixes rocq-archive/coq-serapi#201) * [general] New option `--error-recovery` to enable error recovery (@ejgallego , rocq-archive/coq-serapi#203) * [general] Bump sexplib dependency to v0.13 (@ejgallego , rocq-archive/coq-serapi#204) Fixes incorrect change in rocq-archive/coq-serapi#194. * [sertop] Set default value of allow-sprop to be true in agreement with upstream coq v8.11 and added option '--disallow-sprop' to optionally switch it off (--disallow-sprop forbids using the proof irrelevant SProp sort) (rocq-archive/coq-serapi#199, @pestun) * [sertop] Set default value of allow-sprop to be true in agreement with upstream coq v8.11 and added option '--disallow-sprop' to optionally switch it off (--disallow-sprop forbids using the proof irrelevant SProp sort) (@pestun , rocq-archive/coq-serapi#199) * [sertop] Added option `--topfile` to `sertop` to set top name from a filename (rocq-archive/coq-serapi#197, @pestun) * [deps] Require sexplib >= 0.12 , fixed deprecation warnings (rocq-archive/coq-serapi#194, @ejgallego) * [general] SerAPI is now tested with OCaml 4.08 and 4.09 (rocq-archive/coq-serapi#195 , @ejgallego) * [sertop ] Forward port sername from 0.7.1 (@ejgallego) * [serlib ] Fix rocq-archive/coq-serapi#212 "Segfault on universes" (@ejgallego, reported by @cpitclaudel , rocq-archive/coq-serapi#214) * [serapi ] Fix rocq-archive/coq-serapi#221 "Support COQPATH" (@ejgallego, reported by @cpitclaudel , rocq-archive/coq-serapi#224) * [sertop ] Fix rocq-archive/coq-serapi#222 "Support --indices-matter" (@ejgallego, reported by @cpitclaudel , rocq-archive/coq-serapi#223) * [sertop ] Fix "Stack overflow in main loop" (@pestun , rocq-archive/coq-serapi#216)
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this pull request
Aug 27, 2020
CHANGES: * [general] Require dune >= 2.0 (@ejgallego, ??) * [serapi] New query `Comments` to return all comments in a document (@ejgallego, rocq-archive/coq-serapi#20? , (partially) fixes rocq-archive/coq-serapi#191 , ejgallego/coq-serapi#200 ) * [general] Coq's error recovery is now disabled by default (@ejgallego , fixes rocq-archive/coq-serapi#201) * [general] New option `--error-recovery` to enable error recovery (@ejgallego , rocq-archive/coq-serapi#203) * [general] Bump sexplib dependency to v0.13 (@ejgallego , rocq-archive/coq-serapi#204) Fixes incorrect change in rocq-archive/coq-serapi#194. * [sertop] Set default value of allow-sprop to be true in agreement with upstream coq v8.11 and added option '--disallow-sprop' to optionally switch it off (--disallow-sprop forbids using the proof irrelevant SProp sort) (rocq-archive/coq-serapi#199, @pestun) * [sertop] Set default value of allow-sprop to be true in agreement with upstream coq v8.11 and added option '--disallow-sprop' to optionally switch it off (--disallow-sprop forbids using the proof irrelevant SProp sort) (@pestun , rocq-archive/coq-serapi#199) * [sertop] Added option `--topfile` to `sertop` to set top name from a filename (rocq-archive/coq-serapi#197, @pestun) * [deps] Require sexplib >= 0.12 , fixed deprecation warnings (rocq-archive/coq-serapi#194, @ejgallego) * [general] SerAPI is now tested with OCaml 4.08 and 4.09 (rocq-archive/coq-serapi#195 , @ejgallego) * [sertop ] Forward port sername from 0.7.1 (@ejgallego) * [serlib ] Fix rocq-archive/coq-serapi#212 "Segfault on universes" (@ejgallego, reported by @cpitclaudel , rocq-archive/coq-serapi#214) * [serapi ] Fix rocq-archive/coq-serapi#221 "Support COQPATH" (@ejgallego, reported by @cpitclaudel , rocq-archive/coq-serapi#224) * [sertop ] Fix rocq-archive/coq-serapi#222 "Support --indices-matter" (@ejgallego, reported by @cpitclaudel , rocq-archive/coq-serapi#223) * [sertop ] Fix "Stack overflow in main loop" (@pestun , rocq-archive/coq-serapi#216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212 ; there was an error in the manual syncing of code.
We have added a test, but still this is a problem.
Moreover, in the report in #212 a further issue appears, namely that
the verbose error serialization is way too verbose, this should be
likely addressed separately.