Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nginx from docker compose #1602

Closed
4 tasks done
gulfaraz opened this issue Sep 30, 2024 · 1 comment
Closed
4 tasks done

Remove nginx from docker compose #1602

gulfaraz opened this issue Sep 30, 2024 · 1 comment
Assignees
Labels
devops This involves devops security Pull requests that address a security vulnerability

Comments

@gulfaraz
Copy link
Member

gulfaraz commented Sep 30, 2024

Who is your contact person for this task?

@gulfaraz

Nginx was added to the IBF setup because the vision was that there would be many IBF instances. However, this is not the case anymore. We should move the nginx config outside the docker-compose setup and make it a part of the host machine (similar to the webhook). For development, we can keep a nginx image in the override file without the letsencrypt and certbot dependencies.

What needs to be done

Preview Give feedback

Acceptance Criteria

Preview Give feedback

Additional context

nginx folder in the repo

nginx:
image: staticfloat/nginx-certbot
ports:
- 80:80
- 443:443
environment:
CERTBOT_EMAIL: ${CERTBOT_EMAIL}
ENVSUBST_VARS: FQDN
FQDN: ${FQDN}
volumes:
- ./nginx/conf.d:/etc/nginx/user.conf.d
- ibf-dashboard-root:/var/www/ibf-dashboard
- ./nginx/letsencrypt:/etc/letsencrypt
networks:
web-server-network:
restart: unless-stopped

@gulfaraz gulfaraz added devops This involves devops refine This issue is ready for refinement labels Sep 30, 2024
@gulfaraz gulfaraz added this to the Quality Assurance milestone Sep 30, 2024
@jannisvisser jannisvisser removed the refine This issue is ready for refinement label Oct 15, 2024
@gulfaraz gulfaraz added the security Pull requests that address a security vulnerability label Oct 15, 2024
@gulfaraz gulfaraz self-assigned this Oct 22, 2024
@diderikvw diderikvw changed the title [TASK] Remove nginx from docker compose Remove nginx from docker compose Oct 22, 2024
@gulfaraz gulfaraz removed their assignment Oct 31, 2024
@jannisvisser jannisvisser linked a pull request Nov 11, 2024 that will close this issue
11 tasks
@diderikvw diderikvw assigned gulfaraz and unassigned jannisvisser Nov 19, 2024
@diderikvw diderikvw assigned jannisvisser and unassigned gulfaraz Dec 2, 2024
@gulfaraz
Copy link
Member Author

gulfaraz commented Dec 2, 2024

PR #1815 is merged into master after review with @jannisvisser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops This involves devops security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants