Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat.status page #1565

Merged
merged 7 commits into from
Sep 23, 2024
Merged

Feat.status page #1565

merged 7 commits into from
Sep 23, 2024

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Sep 9, 2024

Describe your changes

PR for item #1520. Decided to implement this by making a separate page in portal itself, accessible through dev-menu.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

  1. Any helpful instructions or clarifications...

@jannisvisser jannisvisser marked this pull request as draft September 9, 2024 11:20
@jannisvisser
Copy link
Contributor Author

@gulfaraz can I ask you for a code review? So not just functional review, but also have a look at how to best do it? (subscriptions/types/angular setup/duplication of code with other services?/etc) I am still getting back into the code a bit, and also in general it's good to try to improve on the current code quality.

image

Copy link
Member

@gulfaraz gulfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mocked a UGA flood and KEN flood to see if the dates are updated. See screenshot.

It works! There are a few refactors and cleanup to do before we merge this.

Screenshot 2024-09-10 at 09 32 13

Nice work!

@jannisvisser jannisvisser marked this pull request as ready for review September 13, 2024 08:05
@jannisvisser
Copy link
Contributor Author

@gulfaraz I processed your comments. In some I left a question back to you. And added 2 extra commits not based on commits. I do consider the current version a potentially shippable version, so I marked this ready for review, and dragged the issue to Review column.

@jannisvisser jannisvisser linked an issue Sep 16, 2024 that may be closed by this pull request
@arsforza arsforza self-requested a review September 23, 2024 09:09
@jannisvisser jannisvisser merged commit bc98256 into master Sep 23, 2024
6 checks passed
@jannisvisser jannisvisser deleted the feat.status-page branch September 23, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Create monitoring dashboard
3 participants