-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat.status page #1565
Feat.status page #1565
Conversation
@gulfaraz can I ask you for a code review? So not just functional review, but also have a look at how to best do it? (subscriptions/types/angular setup/duplication of code with other services?/etc) I am still getting back into the code a bit, and also in general it's good to try to improve on the current code quality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interfaces/IBF-dashboard/src/app/pages/dashboard/dashboard-routing.module.ts
Outdated
Show resolved
Hide resolved
interfaces/IBF-dashboard/src/app/pages/dashboard/dashboard.page.html
Outdated
Show resolved
Hide resolved
interfaces/IBF-dashboard/src/app/pages/dashboard/status-report/status-report.page.html
Show resolved
Hide resolved
interfaces/IBF-dashboard/src/app/pages/dashboard/status-report/status-report.page.html
Outdated
Show resolved
Hide resolved
interfaces/IBF-dashboard/src/app/pages/dashboard/status-report/status-report.page.ts
Outdated
Show resolved
Hide resolved
interfaces/IBF-dashboard/src/app/pages/dashboard/status-report/status-report.page.ts
Outdated
Show resolved
Hide resolved
interfaces/IBF-dashboard/src/app/pages/dashboard/status-report/status-report.page.html
Show resolved
Hide resolved
@gulfaraz I processed your comments. In some I left a question back to you. And added 2 extra commits not based on commits. I do consider the current version a potentially shippable version, so I marked this ready for review, and dragged the issue to Review column. |
Describe your changes
PR for item #1520. Decided to implement this by making a separate page in portal itself, accessible through dev-menu.
Checklist before requesting a review
Notes for the reviewer