Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aggregates icon style #1573

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

gulfaraz
Copy link
Member

@gulfaraz gulfaraz commented Sep 12, 2024

Describe your changes

This PR include style changes in the aggregates component as per design review in this comment.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

  1. I've used tailwind classes where possible.
  2. Here is the screenshot for reference. Note that there is no gap between the icon and the row line.
    Screenshot 2024-09-12 at 15 52 04

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
kianenigma Kian Paimani
@gulfaraz gulfaraz requested a review from arsforza September 12, 2024 13:56
@gulfaraz
Copy link
Member Author

> test:api:all
> node --expose-gc node_modules/.bin/jest --config=jest.api.config.js --runInBand --detectOpenHandles --logHeapUsage

ts-jest[versions] (WARN) Version 4.9.5 of typescript installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=2.7.0 <4.0.0). Please do not report issues in ts-jest if you are using unsupported versions.
 PASS  test/email/floods/email-uga-floods.test.ts (34.559s, 79 MB heap size)
  Should send an email for uga floods
    ✓ default (7902ms)
    ✓ warning (8065ms)
    ✓ warning-to-trigger (9057ms)
    ✓ no-trigger (8938ms)

 PASS  test/email/flash-flood/email-mwi-flash-flood.test.ts (32.056s, 80 MB heap size)
  Should send an email for mwi flash flood
    ✓ default (8715ms)
    ✓ no-trigger (23163ms)

 PASS  test/email/malaria/email-eth-malaria.test.ts (16.319s, 81 MB heap size)
  Should send an email for eth malaria
    ✓ default (7276ms)
    ✓ no-trigger (8965ms)

 PASS  test/email/dengue/email-phl-dengue.test.ts (16.705s, 81 MB heap size)
  Should send an email for phl dengue
    ✓ default (8811ms)
    ✓ no-trigger (7804ms)

 PASS  test/email/floods/email-ssd-floods.test.ts (17.218s, 81 MB heap size)
  Should send an email for ssd floods
    ✓ default (8165ms)
    ✓ no-trigger (8947ms)

 PASS  test/email/drought/email-uga-drought.test.ts (17.851s, 81 MB heap size)
  Should send an email for uga drought
    ✓ triggered in january (8453ms)
    ✓ non triggered any month (9281ms)

 PASS  test/email/typhoon/email-phl-typhoon.test.ts (12.249s, 97 MB heap size)
  Should send an email for phl typhoon
    ✓ default (12037ms)

Test Suites: 7 passed, 7 total
Tests:       15 passed, 15 total
Snapshots:   0 total
Time:        147.5s, estimated 153s
Ran all test suites.

@jannisvisser jannisvisser requested review from jannisvisser and removed request for arsforza September 16, 2024 10:09
@gulfaraz gulfaraz merged commit 95005cc into fix.compact-review Sep 16, 2024
@gulfaraz gulfaraz deleted the fix.aggregates-icon branch September 16, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants