Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix.mock from frontend #1595

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Fix.mock from frontend #1595

merged 3 commits into from
Sep 30, 2024

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Sep 30, 2024

Describe your changes

Resolves bug 832.

  • Changes the front-end feature to use correct path and body based on disaster-type
  • Renames all 'default' scenarios to 'trigger'
  • Does not deal with mocking more scenarios than just trigger and no-trigger from front-end, as that goes beyond the scope of merely fixing this bug.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

  1. All API-tests succeed locally (when changing the hostname back to use port 3000 temporarily)
  2. I have checked from front-end all disaster-types trigger and no-trigger from at least one country.

Copy link
Member

@gulfaraz gulfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get an error on the UI when I mock ETH flood and ETH malaria. It works for ETH drought. I have not tried other countries.

Screen.Recording.2024-09-30.at.12.28.59_1080.mov

@gulfaraz
Copy link
Member

gulfaraz commented Sep 30, 2024

I did not pull the branch code so it didn't have the fix. So you can ignore my previous comment. This PR can be merged.

@jannisvisser jannisvisser merged commit c6ce298 into master Sep 30, 2024
6 checks passed
@jannisvisser jannisvisser deleted the fix.mock-from-frontend branch September 30, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants